-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature webpack legacy #3658
Feature webpack legacy #3658
Conversation
@bbert @mlasak I used https://github.com/stefanpenner/es6-promise here to polyfill promises. From my understanding the library automatically detects whether native promises are supported and polyfills accordingly. With that build playback im IE11 works for me. What do you think? |
@dsilhavy please check my change if it still works for you as expected for legacy. As well i think es-promise must be real dependency not only dev. Changed this, too. |
@bbert Yes, I tested and promises were the only thing missing for IE11. We can consider adding separate builds once we see other platforms with additional missing dependencies. I did not want to create a separate build only for promises. |
@bbert the dash.mediaplayer.min.js bundle is increased by 5 kB (less than 1% increase in byte size of this file). It seams acceptable to me. wdyt? |
This addresses #3619