Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature webpack legacy #3658

Conversation

dsilhavy
Copy link
Collaborator

@dsilhavy dsilhavy commented Jun 4, 2021

This addresses #3619

@dsilhavy
Copy link
Collaborator Author

dsilhavy commented Jun 4, 2021

@bbert @mlasak I used https://github.com/stefanpenner/es6-promise here to polyfill promises. From my understanding the library automatically detects whether native promises are supported and polyfills accordingly. With that build playback im IE11 works for me.

What do you think?

@dsilhavy dsilhavy added this to the 4.0.0 milestone Jun 4, 2021
@mlasak
Copy link
Contributor

mlasak commented Jun 7, 2021

Correct me pls if i'm wrong but i would expect a good polyfill to use the native Promise if present and not just overwriting global one. Maybe it needs to be initialized in a different way ?

If run in chrome with Promises available i see:
image

@mlasak
Copy link
Contributor

mlasak commented Jun 7, 2021

@dsilhavy please check my change if it still works for you as expected for legacy.

As well i think es-promise must be real dependency not only dev. Changed this, too.

@dsilhavy dsilhavy merged commit c8ec44a into Dash-Industry-Forum:development Jun 7, 2021
@mlasak mlasak deleted the feature-webpackLegacy branch June 7, 2021 11:51
@bbert
Copy link
Contributor

bbert commented Jun 7, 2021

@dsilhavy @mlasak so you took the option to include the promise polyfill in output bundle?

@dsilhavy
Copy link
Collaborator Author

dsilhavy commented Jun 7, 2021

@bbert Yes, I tested and promises were the only thing missing for IE11. We can consider adding separate builds once we see other platforms with additional missing dependencies. I did not want to create a separate build only for promises.

@mlasak
Copy link
Contributor

mlasak commented Jun 7, 2021

@bbert the dash.mediaplayer.min.js bundle is increased by 5 kB (less than 1% increase in byte size of this file). It seams acceptable to me. wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants