Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3701 - use prepare rather than postinstall so dashjs can be used as a dependancy #3715

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

davemevans
Copy link
Contributor

See https://docs.npmjs.com/cli/v7/using-npm/scripts

prepare only runs when npm install is run locally without any arguments ie when called, rather than after every install. This means the pre-commit hook is installed for those developing the library, but not those for who it is installed as a dependancy.

@dsilhavy dsilhavy added this to the 4.0.1 milestone Jul 25, 2021
@dsilhavy dsilhavy merged commit d03800c into Dash-Industry-Forum:development Jul 26, 2021
@dsilhavy
Copy link
Collaborator

Thanks @davemevans , I checked it locally using npm pack and it seems to work fine.

@davemevans davemevans deleted the 3701 branch July 26, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants