Bugfix/typescript typings #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ShikiSeiren
commented
Apr 5, 2022
ShikiSeiren
commented
- Updated index.d.ts typings
- Added missing interfaces and classes for all remaining files (excluding offline)
- Adjusted minor issues (wrong tags, inconsistent spelling...) in those files
…erfaces for BaseURL, Mpd, Period, AdaptationSet
…itialise' in various places to its american spelling for consistency
…operties; Rearranged order of interfaces/classes/types to reflect Explorer-Tree and commented accordingly
|
Hi, Can they be fixed as part of this PR or is it better to create a dedicated PR to speed it up? |
…ipt-typings # Conflicts: # index.d.ts # package-lock.json # package.json # src/dash/DashHandler.js # src/streaming/MediaPlayer.js # src/streaming/metrics/utils/DVBErrorsTranslator.js
jigfox
reviewed
Mar 8, 2023
|
|
||
| export type TrackSelectionFunction = (tracks: MediaInfo[]) => MediaInfo[]; | ||
|
|
||
| export interface MediaPlayerClass { |
There was a problem hiding this comment.
the preload-Method is Missing from this interface
There was a problem hiding this comment.
Thanks, added here: 54612bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.