Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/reduce settings url length #3918

Merged
merged 13 commits into from
Apr 22, 2022
Merged

Feature/reduce settings url length #3918

merged 13 commits into from
Apr 22, 2022

Commits on Apr 5, 2022

  1. Initial commit; Added functionality to copyQueryUrl that reduces the … 

    …exported string to 'externalSettings' + actually changed settings
    @ShikiSeiren
    ShikiSeiren committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    ab64ba1 View commit details
    Browse the repository at this point in the history

  2. Removed hardcoded defaultSettings.js, replaced with dynamic method

    @ShikiSeiren
    ShikiSeiren committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    4b84e10 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. Changed externalSettings to also only reflect changed settings; Switc… 

    …hed from using 'debug' as the delimiter between external and internal settigns to '+' as debug is no longer guaranteed in the string
    @ShikiSeiren
    ShikiSeiren committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    c4bdebc View commit details
    Browse the repository at this point in the history

  2. Pulled current dashIF development branch to check for and resolve mer… 

    …ge conflicts before pull request
    @ShikiSeiren
    ShikiSeiren committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    11fe1e4 View commit details
    Browse the repository at this point in the history

  3. Fixed settings who are NaN by default not being filtered out of the URL

    @ShikiSeiren
    ShikiSeiren committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    2a02958 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. Merge branch 'development' of https://github.com/Dash-Industry-Forum/… 

    …dash.js into feature/reduce-settings-url-length

� Conflicts:
�	samples/dash-if-reference-player/app/main.js
    @dsilhavy
    dsilhavy committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    23052cd View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. Only copy array values in "copy settings url" functionality if an ent… 

    …ry has changed
    @dsilhavy
    dsilhavy committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    e84c82d View commit details
    Browse the repository at this point in the history

  2. Removed NaN check

    @ShikiSeiren
    ShikiSeiren committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    4a947f9 View commit details
    Browse the repository at this point in the history

  3. Added code to prevent cmcd array being part of the url if default was… 

    … not changed
    @ShikiSeiren
    ShikiSeiren committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    dfd5603 View commit details
    Browse the repository at this point in the history

  4. Fixed error in function order, shortened array handling line

    @ShikiSeiren
    ShikiSeiren committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    91c300b View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Merge branch 'development' of https://github.com/Dash-Industry-Forum/… 

    …dash.js into feature/reduce-settings-url-length
    @dsilhavy
    dsilhavy committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    9825346 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2022

  1. Merge branch 'development' of https://github.com/Dash-Industry-Forum/… 

    …dash.js into feature/reduce-settings-url-length
    @dsilhavy
    dsilhavy committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    e176b98 View commit details
    Browse the repository at this point in the history

  2. Adjust description text for export settings

    @dsilhavy
    dsilhavy committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    d95cda5 View commit details
    Browse the repository at this point in the history