calculateThroughputByChunkData() fixes #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- shortDurationStartTime need to be reset after a chunkThroughputs.push() otherwise it can lead to spurious 'short duration' throughput measurements. - Moved reset of shortDurationBytesReceived to more optimal location so it is only reset when shortDurationStartTime === 0
…lculation - The length (byte count) of the final piece of 'short duration' data should be included in the throughput calculation otherwise it is ignored which leads to an underestimate.
piersoh
changed the title
calculateThroughputByChunkData() fixes
piersoh
changed the title
calculateThroughputByChunkData() fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes to the
calculateThroughputByChunkData()implementation:Add reset of
shortDurationStartTimeafterchunkThroughputs.push()shortDurationStartTimeneeds to be reset after achunkThroughputs.push()otherwise it can lead to spurious'short duration' throughput measurements - because a previously set
shortDurationStartTimecan end up being incorrectly used if a subsequentdata arrival has a zero
chunkDownloadTime.shortDurationBytesReceivedto more optimal location soit is only reset when
shortDurationStartTime === 0Included length of last piece of short duration data in throughput calculation
data should be included in the throughput calculation otherwise
it is ignored which leads to an underestimate.