Fix: changeType() is Not Fully Implemented on Sony PS5

[agajassi]

Fixes issue/4148 by offering client an option to use useChangeTypeForTrackSwitch flag to avoid errors involving changeType() not being supported on certain platforms.

[vodlogic]

The StreamController seems to just rely on whether the browser supports the changeType property instead of using this configuration. Perhaps we should add this config check there too to ensure consistency thoughout the dash.js code? I think just because the browser supports the changeType function, does not necessarily mean it works properly with the video pipeline of the device.

dash.js/src/streaming/controllers/StreamController.js

Line 485 in 2bc6829

if (keys.length > 0 && sinks[keys[0]].getBuffer().changeType) {

[agajassi]

@vodlogic Yes agree. Added config check in StreamController as well.

[dsilhavy]

@agajassi @vodlogic : I think we should move the settings check to _canSourceBuffersBeReused.

supportsChangeType && settings.get().streaming.buffer.useChangeTypeForTrackSwitch

That way we clearly separate settings from capabilities. We also still apply the changeType transition if the user/app changes the setting after _activateStream.

[dsilhavy]

@agajassi Did you find the time to check my comment yet?

[agajassi]

@agajassi Did you find the time to check my comment yet?
Sorry, I got a little busy over the weekend. Yes I saw your comment. I will give it a try and run some tests today. Thanks for the suggestion.

[agajassi]

I moved settings check from _activateStream to _canSourceBuffersBeReused