Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): TextRequest url property #4211

Merged

Conversation

ondreian
Copy link
Contributor

the type property was fixed in #4191
this is a follow up fix for the url property, and to ensure it never silently fails again.

closes #4210

@dsilhavy dsilhavy added this to the 4.7.1 milestone Jun 16, 2023
@dsilhavy
Copy link
Collaborator

@ondreian Thanks for your PR. Following our contribution guidelines, and since this seems to be your first PR, could you please send me a signed copy of dash.js feedback agreement?

@ondreian
Copy link
Contributor Author

ondreian commented Jun 17, 2023 via email

@dsilhavy dsilhavy modified the milestones: 4.7.1, 4.7.2 Jun 21, 2023
@ondreian
Copy link
Contributor Author

ondreian commented Jun 30, 2023

Taken from CONTRIBUTING.md

If you are submitting code as an individual or on behalf of a company who is not a member of the DASH Industry Forum, then download, sign, scan and email back to the email list the Feedback Agreement. Your code will not be reviewed and accepted by the Admins until this has been received. DASH IF members do not need to take this step, as the Forum's By-Laws already cover your submission to this open source project.

@dsilhavy since I am an employee of Wowza, according to section 8 of the Process for contributing code I shouldn't need to as we (Wowza) are members: https://dashif.org/members/

edit: added all info inline you so you don't have to hunt down what I'm talking about 🙂

@dsilhavy dsilhavy merged commit 56b33ca into Dash-Industry-Forum:development Jul 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

types: TextRequest class type is incorrect due to skipLibChecks: true
2 participants