bugfix/reset-race-conditions #4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @littlespex changes look good. |
dsilhavy
added a commit
that referenced
this pull request
Aug 8, 2023
* WiP: Refactor ABR and throughput logic * Fix unit tests * Fix missing units when a request is aborted * Fix abandon request rule * Fix unit tests * Add PRODUCER_REFERENCE_TIME to list of nodes that should be represented as arrays * Fix bug in requesting fragments * WiP: FetchLoader refactoring * Fix low latency calculation * Remove resource timing API for low latency fetch. No way to eliminate the idle times * Add network API support * Rename some constants * Fix unit tests * Add check for cached response using resource timing API * Fix unit tests * Fix unit tests * Add additional unit test for fetch throughput * Use export default for constants * Add endpoint to get raw throughput data * Move logic to manage active rules to ABRRulesCollection.js to get rid of the handling in RulesContext.js. Also define a single settings object to activate and deactivate all rules * Add byte size weighted arithmetic and harmonic mean calculation * Update definitions in Settings.js and the Typescript file * Fix throughput reporting for content steering * Add MPD throughput when querying by service location * Rename stableBufferTime to bufferTimeDefault * Refactor content steering throughput logic * Add settings description * Add setting for changing the EWMA weight factor * bugfix/reset-race-conditions (#4246) * fix: clear timeout on reset * fix: add null check to prevent errors when _onRemove is called after reset * Compare indices of mediaInfo objects when checking if a track change was rendered. This accounts for content that has no ID attribute for the AdaptationSets. (#4249) * Add additional throughput calculation means and corresponding unit tests * Fix bug in ThroughputController.js * Remove offline sample for now as we working on a new UI. Adjust other samples based on new settings parameters. * Adjust index.d.ts * Fix wrong attribute in L2A rule (#4252) * Fix error in ProtectionModel_21Jan2015.js when closing key session (#4253) * Update index.d.ts * Fix accessing undefined value in _closeKeySessionInternal * Add ThroughputController to index.d.ts * Updates to index.d.ts * Fix linting errors * Update index.d.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for edge case errors that have been captured by Sentry IO around referencing
nullobjects afterresethas been called.