Enable HTML-rendered captions in all browsers #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n resize is now working.
…or IE. It also works in Edge when the tracks are treated as for IE11. Therefore, the isIE11 was changed from isIE11 to isIE11orEdge.
… all tracks are available.
|
@TobbeMobiTV, looks great, thanks! |
KozhinM
added a commit
that referenced
this pull request
Sep 29, 2015
…s-ie-edge Enable HTML-rendered captions in all browsers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full-screen HTML rendering of subtitles is working in IE11 from #797.
Thus we can now enable this rendering in IE11. It also works in Edge similarly to IE11, so the IE11 test was extended to Edge. Fixes #748.
Also made a fix to the sample captioning apps which repeated subtitle tracks because they listened to the wrong event.