Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing another feature I discovered that XML parsing errors are handled differently across platforms and not caught in a sensible way on any. This could lead to the player attempting to continue with an incomplete manifest (Chrome, Safari) or fail but not for the correct reason (Firefox, but only because its error response contains a Processing Instruction node which causes the json conversion to barf).
This PR reliably detects parsererrors and forces a sensible (undefined) response from parser which makes the player act as I believe was intended. IE stop attempting to play the malformed manifest.
Please note I have NOT tested this on IE11/Edge as I don't have access to those browsers right now. Could someone try this out and let me know?