Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPD Patch support #174

Merged
merged 2 commits into from Apr 21, 2024
Merged

MPD Patch support #174

merged 2 commits into from Apr 21, 2024

Conversation

tobbee
Copy link
Contributor

@tobbee tobbee commented Apr 9, 2024

feat: MPD patch support

New URL parameter /patch_ttl

  • PatchLocation
  • publishTime query parameter
  • patch option in query URLs
  • automatically add id to MPD and AdaptationSet if patch is specified
  • return 425 or 410 if patch request is too early or too late

Resolves #155

@tobbee
Copy link
Contributor Author

tobbee commented Apr 15, 2024

As reported by @dsilhavy the code currently uses zero-based indices. This is wrong. XPath should use one-based indices.

@tobbee
Copy link
Contributor Author

tobbee commented Apr 16, 2024

There is a ticket in dash.js for making sure this works. This gives valuable feedback that we have the same understanding of the spec: Dash-Industry-Forum/dash.js#4452

@tobbee
Copy link
Contributor Author

tobbee commented Apr 19, 2024

The https://livesim2.dashif.org instance has now (April 23, 2024) been updated to version v1.3.0, that supports Patch.

A test stream is available at https://livesim2.dashif.org/livesim2/segtimeline_1/patch_60/testpic_2s/Manifest.mpd
To look at a particular patch, one can specify both publishTime and nowDate:

https://livesim2.dashif.org/patch/livesim2/patch_60/segtimeline_1/testpic_2s/Manifest.mpp\?publishTime\=2024-04-16T07:34:38Z\&nowDate\=2024-04-16T07:34:42Z

New URL parameter /patch_ttl
- PatchLocation
- publishTime query parameter
- patch option in query URLs
- automatically add id to MPD and AdaptationSet if patch is specified
- return 425 or 410 if patch request is too early or too late
@tobbee tobbee merged commit 683348d into main Apr 21, 2024
4 checks passed
@tobbee tobbee deleted the patch branch April 21, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MPD Patch
1 participant