Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microphone mute Fn key doesn't work #1006

Open
wessel-novacustom opened this issue Aug 17, 2024 · 9 comments
Open

Microphone mute Fn key doesn't work #1006

wessel-novacustom opened this issue Aug 17, 2024 · 9 comments
Assignees
Labels
bug Something isn't working firmware needs review novacustom_v54_mtl NovaCustom V54 Series novacustom_v56_mtl NovaCustom V56 Series

Comments

@wessel-novacustom
Copy link

Component

Dasharo firmware

Device

NovaCustom V54 14th Gen, NovaCustom V56 14th Gen

Dasharo version

v0.9.0

Dasharo Tools Suite version

No response

Test case ID

No response

Brief summary

The microphone mute Fn key doesn't work, regardless of the OS

How reproducible

100% reproducible.

How to reproduce

  1. Open a sound recording application like Audacity.
  2. Recording the sound while keep talking.
  3. Try to interrupt the recording with Fn + 4 (microphone mute)

Expected behavior

The microphone gets muted.

Actual behavior

The microphone doesn't mute.

Screenshots

No response

Additional context

If possible, this Fn shortcut may be enabled for:

  • NV41 Series (12th Gen only)
  • V54x Series (Meteor Lake, all variants)
  • V56x Series (Meteor Lake, all variants)

It is not needed for other laptop series.

Solutions you've tried

No response

@wessel-novacustom wessel-novacustom added bug Something isn't working needs review labels Aug 17, 2024
@github-actions github-actions bot added firmware novacustom_v54_mtl NovaCustom V54 Series novacustom_v56_mtl NovaCustom V56 Series labels Aug 17, 2024
@mkopec
Copy link
Member

mkopec commented Aug 20, 2024

Added firmware side fix in Dasharo/ec@c93707e

@mkopec
Copy link
Member

mkopec commented Aug 22, 2024

Need to add a quirk to systemd hwdb, something like this: https://github.com/systemd/systemd/blob/d1b04f47e32bd1012ae2e3e6ac9159702463bf15/hwdb.d/60-keyboard.hwdb#L787

but using the actual micmute scancode that is generated on V5x0Tx. A temporary fix can be added to post-install steps.

@wessel-novacustom
Copy link
Author

Yes, that needs to be done

@filipleple
Copy link
Member

filipleple commented Sep 11, 2024

I've additionally enabled the Fn key for NV41 ADL in Dasharo/ec@12d626f and added the quirks for NV41 ADL and V5x to systemd in systemd/systemd@40ef5cc . The combination works as expected now:

micmute

@wessel-novacustom
Copy link
Author

I've additionally enabled the Fn key for NV41 ADL in Dasharo/ec@12d626f and added the quirks for NV41 ADL and V5x to systemd in systemd/systemd@40ef5cc . The combination works as expected now [ ... ]

Amazing! Hopefully, the same can easily be done on the V54 Series (-TU and NVIDIA variants), as well as the V56 Series (-TU and NVIDIA variants), while it's being skipped for the other variants.

I will close the issue once it has been integrated in a release.

@mkopec
Copy link
Member

mkopec commented Sep 11, 2024

On the firmware side this is integrated in rc5 for nvidia models. The fix is also implemented for -TU models, but it's not included in any release for those models yet.

@philipandag
Copy link

On V540TND v0.9.1-rc5 adding the change works #1006 (comment)

You only need to add the line:

KEYBOARD_KEY_81=f20

to /etc/udev/hwdb.d/60-keyboard.hwdb under evdev:atkbd:dmi:bvn*:bvr*:svnNotebook:pnV5xTNX_TND_TNE:*, run udevadm trigger and reboot. Then the mic mute key works perfectly.

@filipleple
Copy link
Member

Just to clarify, manually adding the line shouldn't be necessary after the next systemd release, which should happen in a week or two. Then, just keeping the OS updated should do it.

@wessel-novacustom
Copy link
Author

Great progress!

Is it also possible to enable this for Windows? It is not working on a V560TND running rc5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firmware needs review novacustom_v54_mtl NovaCustom V54 Series novacustom_v56_mtl NovaCustom V56 Series
Projects
Status: No status
Development

No branches or pull requests

5 participants