Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UefiPayloadPkg/NetworkDrivers/build-ipxe.sh: add #13

Closed
wants to merge 7 commits into from

Conversation

macpijan
Copy link
Contributor

Signed-off-by: Maciej Pijanowski maciej.pijanowski@3mdeb.com

@macpijan macpijan requested a review from miczyg1 April 22, 2022 09:22
@mkopec
Copy link
Member

mkopec commented May 10, 2022

This script doesn't handle custom configuration like enabling DOWNLOAD_PROTO_HTTPS, IMAGE_TRUST_CMD etc in src/config/general.h.

@macpijan
Copy link
Contributor Author

Can we extend that somehow? Or in some other way? Generally, I have a problem with shipping some iPXE binary with no information how it was built - and this is what I'd like we fix in this MR.

@miczyg1
Copy link
Contributor

miczyg1 commented May 11, 2022

Can we extend that somehow? Or in some other way? Generally, I have a problem with shipping some iPXE binary with no information how it was built - and this is what I'd like we fix in this MR.

This can be easily patched in the script...

@pietrushnic
Copy link
Contributor

I will try to move this little bit forward since I see huge need for controllable ipxe binary.

@pietrushnic
Copy link
Contributor

@mkopec @miczyg1 I tried to address your concerns, I think we should issue this script in dasharo coreboot common base. Please let me know WDTYT.

@pietrushnic
Copy link
Contributor

Support added here Dasharo/coreboot@6dc9057

@pietrushnic
Copy link
Contributor

I guess we could remove ipxe.efi file

@pietrushnic
Copy link
Contributor

Shall we rewrite git history to remove ipxe.efi ?

@macpijan
Copy link
Contributor Author

macpijan commented Oct 25, 2022

Shall we rewrite git history to remove ipxe.efi ?

I have mostly cleaned that up in https://github.com/Dasharo/edk2/commits/dasharo-cleanup preparing for a rebase.

There is only a single commit left adding iPXE binary: b3bfaf3

Previously there were a few changes of the binary in the history.

@pietrushnic
Copy link
Contributor

@macpijan do you want me to rebase on dasharo-cleanup and get rid of last commit iPXE binary? I can also test results on OptiPlex.

macpijan and others added 7 commits October 26, 2022 22:05
Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
…for config changes

Signed-off-by: Piotr Król <piotr.krol@3mdeb.com>
…g compilation

Signed-off-by: Piotr Król <piotr.krol@3mdeb.com>
Signed-off-by: Piotr Król <piotr.krol@3mdeb.com>
…t and disable CONFIG_BZIMAGE

Signed-off-by: Piotr Król <piotr.krol@3mdeb.com>
Signed-off-by: Piotr Król <piotr.krol@3mdeb.com>
…GE_BZIMAGE disabling

Signed-off-by: Piotr Król <piotr.krol@3mdeb.com>
@pietrushnic pietrushnic changed the base branch from dasharo to dasharo-cleanup October 26, 2022 20:37
@pietrushnic
Copy link
Contributor

@macpijan I rebased this branch on dasharo-cleanup and booting xcp-ng still works, so I guess we can assume dasharo-cleanup get through some basic testing. Now I will proceed with removing ipxe.efi from history.

@miczyg1
Copy link
Contributor

miczyg1 commented Nov 15, 2022

I have solved building iPXE with coreboot toolchain and hook it up to EDK2:
#34
https://github.com/Dasharo/coreboot/pull/259/files

Can we close this PR?

@miczyg1 miczyg1 closed this Jun 13, 2023
@miczyg1 miczyg1 deleted the explain-ipxe-build branch June 13, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants