prompt population of inputs and outputs upon navigation up or down [W…

…A-72] (#687)
DataBiosphere · Nov 21, 2019 · fbb7af8 · fbb7af8
1 parent b19186b
commit fbb7af8
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Job Manager Change Log
 
+## v1.5.4 Release Notes
+
+### Fixed a bug where workflow inputs/outputs were not always displayed correctly without browser reload.
+
 ## v1.5.3 Release Notes
 
 ### Fixed a bug where workflow-level errors are not displayed correctly in the Errors Card on the Job Details page.

diff --git a/ui/src/app/job-details/job-details.component.ts b/ui/src/app/job-details/job-details.component.ts
@@ -112,5 +112,11 @@ export class JobDetailsComponent implements OnInit {
     if (this.job.extensions.tasks) {
       this.taskTabs.timingDiagram.buildTimelineData(this.job.extensions.tasks);
     }
+    if (objectNotEmpty(this.job.inputs)) {
+      this.taskTabs.inputsTab.populateEntryKeys(this.job.inputs);
+    }
+    if (objectNotEmpty(this.job.outputs)) {
+      this.taskTabs.outputsTab.populateEntryKeys(this.job.outputs);
+    }
   }
 }
diff --git a/ui/src/app/job-details/resources/resources-table/resources-table.component.ts b/ui/src/app/job-details/resources/resources-table/resources-table.component.ts
@@ -20,7 +20,7 @@ export class JobResourcesTableComponent implements OnInit {
   constructor(private authService: AuthService) {}
 
   ngOnInit() {
-    this.entryKeys = Object.keys(this.entries || {}).sort();
+    this.populateEntryKeys(this.entries);
   }
 
   getResourceURL(key: string): string {
@@ -30,4 +30,8 @@ export class JobResourcesTableComponent implements OnInit {
   isResourceURL(key: string): boolean {
     return ResourceUtils.isResourceURL(this.entries[key]);
   }
+
+  populateEntryKeys(entries) {
+    this.entryKeys = Object.keys(entries || {}).sort();
+  }
 }
diff --git a/ui/src/app/job-details/tabs/tabs.component.html b/ui/src/app/job-details/tabs/tabs.component.html
@@ -135,11 +135,11 @@
     </mat-tab>
     <!-- Task inputs tab -->
     <mat-tab *ngIf="hasInputs(job)" label="Inputs">
-      <jm-resources-table [entries]="job.inputs"></jm-resources-table>
+      <jm-resources-table #inputsTab [entries]="job.inputs"></jm-resources-table>
     </mat-tab>
     <!-- Task outputs tab -->
     <mat-tab *ngIf="hasOutputs(job)" label="Outputs">
-      <jm-resources-table [entries]="job.outputs"></jm-resources-table>
+      <jm-resources-table #outputsTab [entries]="job.outputs"></jm-resources-table>
     </mat-tab>
     <!-- Secondary Labels tab -->
     <mat-tab *ngIf="job.labels" label="Labels">

diff --git a/ui/src/app/job-details/tabs/tabs.component.ts b/ui/src/app/job-details/tabs/tabs.component.ts
@@ -28,6 +28,8 @@ export class JobTabsComponent implements OnInit, OnChanges {
   @ViewChild(JobFailuresTableComponent) failuresTable: JobFailuresTableComponent;
   @ViewChild(JobTimingDiagramComponent) timingDiagram: JobTimingDiagramComponent;
   @ViewChild('tabsPanel') tabsPanel;
+  @ViewChild('inputsTab') inputsTab;
+  @ViewChild('outputsTab') outputsTab;
 
   database = new TasksDatabase(this.tasks);
   dataSource: TasksDataSource | null;