Update create-react-app and dependencies #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calbach
approved these changes
Mar 24, 2022
tjennison-google
force-pushed
the
tj-update
branch
from
403331d
to
91cd1cb
Compare
Transitively this required a lot of updates. Notably: * It required newer versions of NPM, Node.js, and the Typescript compiler. Either one of those or the way CRA configures them caused more errors to be flagged in tests which had to be fixed. * randomstring relies on randombytes which needs a newer version to work with the new Node.js environment. I had to override it in package.json for now but presumably it will be updated eventually.
tjennison-google
force-pushed
the
tj-update
branch
from
91cd1cb
to
d87cfd6
Compare
* Adds ellipses for TreeGrid titles, wrapping for TreeGrid body cells, and support for TreeGrids wider than their parent. * Refactors the list of entity filters and attributes into a shared function so it can be used for both the preview and the attribute selection.
tjennison-google
force-pushed
the
tj-update
branch
2 times, most recently
from
adf515d
to
6eb0ce6
Compare
Transitively this required a lot of updates. Notably: * It required newer versions of NPM, Node.js, and the Typescript compiler. Either one of those or the way CRA configures them caused more errors to be flagged in tests which had to be fixed. * One fallout from this was that AttributeValues from SearchEntityInstances needed to be made nullable to correctly allow null fields to be returned (e.g. standard_concept). Unfortunately, this doesn't doesn't work correctly for map type objects due to OAI/OpenAPI-Specification#1368. Upgrading to OpenAPI 3.1 will provide a new, working syntax for this but will also require many other changes to the schema. In the meantime, "| null" is manually added to the generated code. * randomstring relies on randombytes which needs a newer version to work with the new Node.js environment. I had to override it in package.json for now but presumably it will be updated eventually.
tjennison-google
force-pushed
the
tj-update
branch
from
6eb0ce6
to
153bb2c
Compare
tjennison-google
added a commit
that referenced
this pull request
Mar 25, 2022
This reverts commit fe2cd85. I rebased incorrectly while cleaning up the last nits and accidentally merged a follow up commit into this one. Revert the combination change and will recreate pull requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transitively this required a lot of updates. Notably:
compiler. Either one of those or the way CRA configures them caused
more errors to be flagged in tests which had to be fixed.
with the new Node.js environment. I had to override it in package.json
for now but presumably it will be updated eventually.