Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recognition of Conda virtual environments #2421

Closed
ibebio opened this issue Oct 16, 2018 · 1 comment
Closed

Add recognition of Conda virtual environments #2421

ibebio opened this issue Oct 16, 2018 · 1 comment

Comments

@ibebio
Copy link
Contributor

ibebio commented Oct 16, 2018

Hi,
we used Conda virtual environments instead of virtualenv and ran into the issue that toil does not recognize that it is running inside a Conda virtual environment. _toil_worker could thus not be found, without explicitely setting the PATH variable to point to its location in .bash_profile.

Extending the check for virtual environments inVirtualEnv() in src/toil/init.py to
return hasattr(sys, 'real_prefix') or 'CONDA_DEFAULT_ENV' in os.environ
solved the problem for us. Would this change make sense, and should I submit a pull request?

Thanks, Ilja

┆Issue is synchronized with this JIRA Story
┆Issue Number: TOIL-377

@DailyDreaming
Copy link
Member

@ibebio Yes, that sounds like a sensible change. Please do submit a PR! Thanks for posting this. :)

DailyDreaming added a commit that referenced this issue Oct 17, 2018
Add recognition of conda virtual envs, resolves #2421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants