made changes to lsf.py to make it compatible on lsf9 and lsf10 with p… #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-c
reviewed
Jun 27, 2019
drjrm3
reviewed
Jun 28, 2019
|
@adamnovak When you get a chance could you take a look. This is to incorporate python3.x compatibility for lsf9/10 integration. |
adamnovak
requested changes
Jul 1, 2019
changed all character encodings to utf-8 to make encoding consistent across code base.
|
@adamnovak pushed changes for character encodings. |
mr-c
reviewed
Jul 1, 2019
adamnovak
approved these changes
Jul 1, 2019
|
This PR will fix #2724 |
|
@adamnovak any status update on this? |
|
OK, I've imported this in for full testing. When that passes we can go ahead and merge it. |
|
Thank you @drkennetz ! |
|
Thanks for your help all! @mr-c @adamnovak @drjrm3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ython3x