Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fact URL always shows the first fact (hello_world example) #370

Closed
RacingTadpole opened this issue Jul 29, 2016 · 2 comments
Closed

Fact URL always shows the first fact (hello_world example) #370

RacingTadpole opened this issue Jul 29, 2016 · 2 comments
Labels

Comments

@RacingTadpole
Copy link

When I run slicer serve in the example/hello_world directory, and visit

http://localhost:5000/cube/irbd_balance/fact/20,

regardless of which id (eg. 20) I put at the end of the URL, I always get the same fact, with __fact_key__: 1. Have I missed something? Thanks!

@Stiivi Stiivi added the bug label Aug 1, 2016
@KhaledTo
Copy link
Contributor

KhaledTo commented Oct 29, 2016

Hi, this seems to happen in cubes/sql/browser.py in the fact function.

In the condition :
condition = statement.columns[FACT_KEY_LABEL] == key_value

The first row (with the first id ) is always returned, it doesn't matter which key_value you pass.

KhaledTo added a commit to KhaledTo/cubes that referenced this issue Oct 29, 2016
Stiivi added a commit that referenced this issue Mar 10, 2017
Fix BUG #370 by getting fact table key column defined in StarSchema
@Stiivi
Copy link
Member

Stiivi commented Mar 11, 2017

This seems to be fixed.

@Stiivi Stiivi closed this as completed Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants