[CORE] Port all edges from original POC #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edznux-dd
approved these changes
Jun 21, 2023
| ) | ||
|
|
||
| // GremlinInputProcessor transform a graph model object to a map suitable for consumption by a gremllin traversal. | ||
| func GremlinInputProcessor[T any](_ context.Context, entry interface{}) (map[string]any, error) { |
There was a problem hiding this comment.
Suggested change
| func GremlinInputProcessor[T any](_ context.Context, entry interface{}) (map[string]any, error) { | |
| func GremlinInputProcessor[T any](_ context.Context, entry any) (map[string]any, error) { |
| } | ||
|
|
||
| // structToMap creates a map from a simple input struct. | ||
| func structToMap(in interface{}) (map[string]any, error) { |
There was a problem hiding this comment.
Suggested change
| func structToMap(in interface{}) (map[string]any, error) { | |
| func structToMap(in any) (map[string]any, error) { |
| } | ||
|
|
||
| // Traversal expects a list of podPatchGroup serialized as mapstructure for injection into the graph. | ||
| // Fo each podPatchGroup, the traversal will: 1) find the role vertex with matching storeID, 2) find the |
There was a problem hiding this comment.
Suggested change
| // Fo each podPatchGroup, the traversal will: 1) find the role vertex with matching storeID, 2) find the | |
| // For each podPatchGroup, the traversal will: 1) find the role vertex with matching storeID, 2) find the |
| } | ||
|
|
||
| // Traversal expects a list of containerAttachGroup serialized as mapstructure for injection into the graph. | ||
| // Fo each containerAttachGroup, the traversal will: 1) find the pod vertex with matching storeID, 2) find the |
There was a problem hiding this comment.
Suggested change
| // Fo each containerAttachGroup, the traversal will: 1) find the pod vertex with matching storeID, 2) find the | |
| // For each containerAttachGroup, the traversal will: 1) find the pod vertex with matching storeID, 2) find the |
| } | ||
|
|
||
| // containerEscapeTraversal expects a list of containerEscapeGroup serialized as mapstructure for injection into the graph. | ||
| // Fo each containerEscapeGroup, the traversal will: 1) find the container with matching storeID, 2) find the |
There was a problem hiding this comment.
Suggested change
| // Fo each containerEscapeGroup, the traversal will: 1) find the container with matching storeID, 2) find the | |
| // For each containerEscapeGroup, the traversal will: 1) find the container with matching storeID, 2) find the |
| } | ||
|
|
||
| // Traversal expects a list of identityGroup serialized as mapstructure for injection into the graph. | ||
| // Fo each identityGroup, the traversal will: 1) find the container with matching storeID, 2) find the |
There was a problem hiding this comment.
Suggested change
| // Fo each identityGroup, the traversal will: 1) find the container with matching storeID, 2) find the | |
| // For each identityGroup, the traversal will: 1) find the container with matching storeID, 2) find the |
| } | ||
|
|
||
| // Traversal expects a list of podAttachGroup serialized as mapstructure for injection into the graph. | ||
| // Fo each podAttachGroup, the traversal will: 1) find the pod vertex with matching storeID, 2) find the |
There was a problem hiding this comment.
Suggested change
| // Fo each podAttachGroup, the traversal will: 1) find the pod vertex with matching storeID, 2) find the | |
| // For each podAttachGroup, the traversal will: 1) find the pod vertex with matching storeID, 2) find the |
| // Traversal expects a list of podPatchGroup serialized as mapstructure for injection into the graph. | ||
| // Fo each podPatchGroup, the traversal will: 1) find the role vertex with matching storeID, 2) find the | ||
| // pod vertices for each matching storeID, and 3) add a POD_PATCH edge between the two vertices. | ||
| // TODO this only handles the same namespace case. What do we do if its all namespaces to avoid edge count blowing up? |
There was a problem hiding this comment.
hmm if the namespace aren't a security boundary in this case, shouldn't we do "too many edge but we don't missing something obvious" rather than "we lack visibility but we have a nice graph" approach (at least at first?)
There was a problem hiding this comment.
I think you're right but its gonna be a tricky gremlin query. going to leave it as is for this PR and add this case in a subequent one (ASAP)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all the edges from the original POC