Add autoscaling proto + JSON Schema generation #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vboulineau
force-pushed
the
vboulineau/autoscaling
branch
from
716fc22
to
85f28dd
Compare
vboulineau
changed the title
vboulineau
force-pushed
the
vboulineau/autoscaling
branch
3 times, most recently
from
d44c320
to
49b7b96
Compare
vboulineau
force-pushed
the
vboulineau/autoscaling
branch
from
49b7b96
to
da6d997
Compare
vboulineau
force-pushed
the
vboulineau/autoscaling
branch
2 times, most recently
from
ee64bda
to
877863e
Compare
AliDatadog
reviewed
May 3, 2024
Comment on lines
22
to
29
| WorkloadHorizontalData manual = 1; // Manual is the manual override values for the workload | ||
| WorkloadHorizontalData auto = 2; // Auto is the periodic recommendation values for the workload |
There was a problem hiding this comment.
❓ Why do we need different types for the auto recommendation or the manual override? Aren't we just applying one of them in the Agent ?
There was a problem hiding this comment.
The controller will decide to apply manual/auto based on if dryrun or not.
fisherevans
approved these changes
May 3, 2024
vboulineau
force-pushed
the
vboulineau/autoscaling
branch
3 times, most recently
from
390aecf
to
e5b39ad
Compare
vboulineau
force-pushed
the
vboulineau/autoscaling
branch
from
e5b39ad
to
cab5f76
Compare
AliDatadog
approved these changes
May 15, 2024
vboulineau
force-pushed
the
vboulineau/autoscaling
branch
from
cab5f76
to
4453a57
Compare
MovieStoreGuy
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
May 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/DataDog/agent-payload/v5](https://togithub.com/DataDog/agent-payload) | `v5.0.115` -> `v5.0.118` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/core/config](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.4` -> `v0.54.0-rc.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/core/hostname/hostnameinterface](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.4` -> `v0.54.0-rc.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/core/log](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.4` -> `v0.54.0-rc.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.4` -> `v0.54.0-rc.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline/logsagentpipelineimpl](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.4` -> `v0.54.0-rc.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.4` -> `v0.54.0-rc.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/config/model](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.4` -> `v0.54.0-rc.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/config/setup](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.4` -> `v0.54.0-rc.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/proto](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.4` -> `v0.54.0-rc.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/trace](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.4` -> `v0.54.0-rc.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-api-client-go/v2](https://togithub.com/DataDog/datadog-api-client-go) | `v2.25.0` -> `v2.26.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/sketches-go](https://togithub.com/DataDog/sketches-go) | `v1.4.4` -> `v1.4.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>DataDog/agent-payload (github.com/DataDog/agent-payload/v5)</summary> ### [`v5.0.118`](https://togithub.com/DataDog/agent-payload/releases/tag/v5.0.118) [Compare Source](https://togithub.com/DataDog/agent-payload/compare/v5.0.117...v5.0.118) #### What's Changed - Regen from master due to Go version chnge by [@​vboulineau](https://togithub.com/vboulineau) in [DataDog/agent-payload#315 - \[NPM-3384] Add CCMEnabled field by [@​hmahmood](https://togithub.com/hmahmood) in [DataDog/agent-payload#314 **Full Changelog**: DataDog/agent-payload@v5.0.117...v5.0.118 ### [`v5.0.117`](https://togithub.com/DataDog/agent-payload/releases/tag/v5.0.117) [Compare Source](https://togithub.com/DataDog/agent-payload/compare/v5.0.116...v5.0.117) #### What's Changed - Add autoscaling proto + JSON Schema generation by [@​vboulineau](https://togithub.com/vboulineau) in [DataDog/agent-payload#302 - USMON-980: Enhance KafkaAggregation with Error Code and Latency Support by [@​DanielLavie](https://togithub.com/DanielLavie) in [DataDog/agent-payload#311 **Full Changelog**: DataDog/agent-payload@v5.0.116...v5.0.117 ### [`v5.0.116`](https://togithub.com/DataDog/agent-payload/releases/tag/v5.0.116) [Compare Source](https://togithub.com/DataDog/agent-payload/compare/v5.0.115...v5.0.116) #### What's Changed - \[CSM] Add AWS Security Credentials in process context by [@​Gui774ume](https://togithub.com/Gui774ume) in [DataDog/agent-payload#312 - \[NPM] Add map of TCP failures to connections object by [@​akarpz](https://togithub.com/akarpz) in [DataDog/agent-payload#301 #### New Contributors - [@​akarpz](https://togithub.com/akarpz) made their first contribution in [DataDog/agent-payload#301 **Full Changelog**: DataDog/agent-payload@v5.0.115...v5.0.116 </details> <details> <summary>DataDog/datadog-api-client-go (github.com/DataDog/datadog-api-client-go/v2)</summary> ### [`v2.26.0`](https://togithub.com/DataDog/datadog-api-client-go/releases/tag/v2.26.0) [Compare Source](https://togithub.com/DataDog/datadog-api-client-go/compare/v2.25.0...v2.26.0) <!-- Release notes generated using configuration in .github/release.yml at v2.26.0 --> #### What's Changed ##### Fixed - fix case search documentation by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2469 ##### Added - Add support variablesFromScript in Synthetics API test by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2471 - Add JSONSchema assertion support to API and multistep tests by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2448 - add 1 day logs to usage api docs by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2477 - Update UserTeamIncluded to include teams by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2482 - Security Monitoring - Make Default Tags available in the response by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2491 - Add flex logs storage tier by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2493 ##### Changed - Rename the Cloud Workload Security tag to CSM Threats by [@​api-clients-generation-pipeline](https://togithub.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2481 **Full Changelog**: DataDog/datadog-api-client-go@v2.25.0...v2.26.0 </details> <details> <summary>DataDog/sketches-go (github.com/DataDog/sketches-go)</summary> ### [`v1.4.5`](https://togithub.com/DataDog/sketches-go/releases/tag/v1.4.5) [Compare Source](https://togithub.com/DataDog/sketches-go/compare/v1.4.4...v1.4.5) #### What's Changed - go.mod: update google.golang.org/protobuf to v1.32.0 & set go directive to 1.18 by [@​darccio](https://togithub.com/darccio) in [DataDog/sketches-go#78 #### New Contributors - [@​darccio](https://togithub.com/darccio) made their first contribution in [DataDog/sketches-go#78 **Full Changelog**: DataDog/sketches-go@v1.4.4...v1.4.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2OC4xMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Autoscaling proto and JSON schema generation plugin (used for autoscaling)/
Upgrade to Go 1.21 to avoid space diffs between local and CI. All repos using agent-payload should be >= 1.21 already.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Reviewers: please see the review guidelines.