Updated protobuf files to be generated with protoc-gen-1.34.1 #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielLavie
approved these changes
May 9, 2024
paulcacheux
approved these changes
May 9, 2024
leeavital
approved these changes
May 9, 2024
There was a problem hiding this comment.
As part of this, could we also pin the protobuf version generator to avoid situations like this in the future?
It looks like we pull in latest here https://github.com/DataDog/agent-payload/blob/master/Rakefile#L91
I agree |
sgnn7
approved these changes
May 9, 2024
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
May 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/DataDog/agent-payload/v5](https://togithub.com/DataDog/agent-payload) | `v5.0.114` -> `v5.0.115` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/core/config](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.2` -> `v0.54.0-rc.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/core/hostname/hostnameinterface](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.2` -> `v0.54.0-rc.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/core/log](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.2` -> `v0.54.0-rc.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.2` -> `v0.54.0-rc.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline/logsagentpipelineimpl](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.2.0.20240502211937-f7706eb2beae` -> `v0.54.0-rc.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.2` -> `v0.54.0-rc.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/config/model](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.2` -> `v0.54.0-rc.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/config/setup](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.2` -> `v0.54.0-rc.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/proto](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.2` -> `v0.54.0-rc.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/trace](https://togithub.com/DataDog/datadog-agent) | `v0.54.0-rc.2` -> `v0.54.0-rc.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>DataDog/agent-payload (github.com/DataDog/agent-payload/v5)</summary> ### [`v5.0.115`](https://togithub.com/DataDog/agent-payload/releases/tag/v5.0.115) [Compare Source](https://togithub.com/DataDog/agent-payload/compare/v5.0.114...v5.0.115) #### What's Changed - Update the CODEOWNERS for metrics and logs protobufs to APR by [@​jszwedko](https://togithub.com/jszwedko) in [DataDog/agent-payload#298 - Fix generated proto files by [@​DanielLavie](https://togithub.com/DanielLavie) in [DataDog/agent-payload#305 - USMON-930: Remove DataStreamsAggregations deprecated fields by [@​DanielLavie](https://togithub.com/DanielLavie) in [DataDog/agent-payload#304 - Update CODEOWNERS by [@​guyarb](https://togithub.com/guyarb) in [DataDog/agent-payload#308 - Updated protobuf files to be generated with protoc-gen-1.34.1 by [@​guyarb](https://togithub.com/guyarb) in [DataDog/agent-payload#307 - usm: db: Added settings for generic DB monitoring, and specially postgres by [@​guyarb](https://togithub.com/guyarb) in [DataDog/agent-payload#303 - Pin protobuf generator versions by [@​leeavital](https://togithub.com/leeavital) in [DataDog/agent-payload#310 - \[process payload] Mark \*.proto_builder.go libraries as generated by [@​leeavital](https://togithub.com/leeavital) in [DataDog/agent-payload#309 #### New Contributors - [@​jszwedko](https://togithub.com/jszwedko) made their first contribution in [DataDog/agent-payload#298 **Full Changelog**: DataDog/agent-payload@v5.0.114...v5.0.115 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extracting irrelevant automatic changes from the PR #303
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Reviewers: please see the review guidelines.