馃攰 add view document_count in non-view events #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help investigate why view event counts are often incorrect.
bcaudan
reviewed
Dec 21, 2022
It turns out that the View `_dd.document_version` is replaced by another unrelated version in the backend. I wanted to duplicate this field so we can keep the original in views. Because unknown `_dd` fields are discarded from View events by the backend, I chose to put it in the global context, similarly to #1757 (and other before).
Codecov Report
@@ Coverage Diff @@
## main #1892 +/- ##
==========================================
- Coverage 93.21% 93.20% -0.02%
==========================================
Files 138 138
Lines 5250 5256 +6
Branches 1182 1184 +2
==========================================
+ Hits 4894 4899 +5
- Misses 356 357 +1
馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more |
bcaudan
approved these changes
Jan 3, 2023
BenoitZugmeyer
deleted the
benoit/event-counters--add-view-document-count-on-child-events
branch
BenoitZugmeyer
added a commit
that referenced
this pull request
Jan 19, 2023
This reverts commit 1dcc3a9.
BenoitZugmeyer
added a commit
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Help investigate why view event counts are often incorrect.
Changes
Add
_dd.view.document_countreflecting the current view document count at the moment when the event is collected. In theory, the final_dd.document_counton View events will alway be greater than child events_dd.view.document_count, because any child event collected will trigger a scheduled view update. Let's verify that.Testing
I have gone over the contributing documentation.