Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 add view document_count in non-view events #1892

Commits on Dec 20, 2022

  1. 🔊 add view document_count in non-view events

    This will help investigate why view event counts are often incorrect.
    BenoitZugmeyer committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    965a30f View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. 🐛 move document_version to global context

    It turns out that the View `_dd.document_version` is replaced by another
    unrelated version in the backend. I wanted to duplicate this field so we
    can keep the original in views.
    
    Because unknown `_dd` fields are discarded from View events by the
    backend, I chose to put it in the global context, similarly to #1757
    (and other before).
    BenoitZugmeyer committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    56435da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a61e0b View commit details
    Browse the repository at this point in the history