Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

โš—๐Ÿ› [RUMF-1296] use pointerup to trigger click actions #1958

Merged
merged 9 commits into from
Jan 30, 2023

Commits on Jan 20, 2023

  1. โ™ป๏ธ [RUMF-1296] simplify a bit how we compute input user activity

    This commit will help implementing click actions triggered by pointerup
    behind a FF.
    BenoitZugmeyer committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    7dddaa9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38c32ae View commit details
    Browse the repository at this point in the history
  3. ๐Ÿ› [RUMF-1296] ignore non-primary pointer events

    In 'listenActionEvents', we expect that a 'click' event is preceded by
    a single 'pointerdown' event. It turns out this is not always the case
    on multitouch devices.
    
    This issue would be amplified when listening to 'pointerup' events.
    
    Let's just focus on the 'primary' pointer events. This will ignore
    secondary touches until we implement proper support for them (if ever).
    BenoitZugmeyer committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    a1c8333 View commit details
    Browse the repository at this point in the history
  4. โš—๐Ÿ› [RUMF-1296] use pointerup to trigger click actions

    This slightly change the action beginning, but takes any activity
    produced by 'pointerup' 'mouseup' 'touchend' events into account. If
    those actions don't produce any activity, the action start is likely to
    be the same as before, since 'pointerup/mouseup/touchend' should be
    triggered very close to the 'click' event.
    BenoitZugmeyer committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    238488e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7e96c15 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Configuration menu
    Copy the full SHA
    c580994 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Configuration menu
    Copy the full SHA
    87ecde7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3225f3d View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Configuration menu
    Copy the full SHA
    a9e0a39 View commit details
    Browse the repository at this point in the history