-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
โ๐ [RUMF-1296] use pointerup to trigger click actions #1958
โ๐ [RUMF-1296] use pointerup to trigger click actions #1958
Commits on Jan 20, 2023
-
โป๏ธ [RUMF-1296] simplify a bit how we compute input user activity
This commit will help implementing click actions triggered by pointerup behind a FF.
Configuration menu - View commit details
-
Copy full SHA for 7dddaa9 - Browse repository at this point
Copy the full SHA 7dddaa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38c32ae - Browse repository at this point
Copy the full SHA 38c32aeView commit details -
๐ [RUMF-1296] ignore non-primary pointer events
In 'listenActionEvents', we expect that a 'click' event is preceded by a single 'pointerdown' event. It turns out this is not always the case on multitouch devices. This issue would be amplified when listening to 'pointerup' events. Let's just focus on the 'primary' pointer events. This will ignore secondary touches until we implement proper support for them (if ever).
Configuration menu - View commit details
-
Copy full SHA for a1c8333 - Browse repository at this point
Copy the full SHA a1c8333View commit details -
โ๐ [RUMF-1296] use pointerup to trigger click actions
This slightly change the action beginning, but takes any activity produced by 'pointerup' 'mouseup' 'touchend' events into account. If those actions don't produce any activity, the action start is likely to be the same as before, since 'pointerup/mouseup/touchend' should be triggered very close to the 'click' event.
Configuration menu - View commit details
-
Copy full SHA for 238488e - Browse repository at this point
Copy the full SHA 238488eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e96c15 - Browse repository at this point
Copy the full SHA 7e96c15View commit details
Commits on Jan 25, 2023
-
Merge remote-tracking branch 'origin/main' into benoit/frustration-siโฆ
โฆgnals--track-pointerup
Configuration menu - View commit details
-
Copy full SHA for c580994 - Browse repository at this point
Copy the full SHA c580994View commit details
Commits on Jan 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 87ecde7 - Browse repository at this point
Copy the full SHA 87ecde7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3225f3d - Browse repository at this point
Copy the full SHA 3225f3dView commit details
Commits on Jan 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a9e0a39 - Browse repository at this point
Copy the full SHA a9e0a39View commit details