Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ fix Jasmine deprecation warning in unit tests/IE #1974

Merged
merged 1 commit into from Jan 30, 2023

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

"DEPRECATION: describe with no children (describe() or it()) is deprecated and will be removed in a future version of Jasmine."

Changes

Wrapping the describe in a if statement is not really pretty. Ideally we would use "shadow dom" APIs inside beforeEach or it blocks instead of describe, but this prevents us from using a list to generate test cases.

I think it's acceptable until we eventually drop IE support.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

"DEPRECATION: describe with no children (describe() or it()) is
deprecated and will be removed in a future version of Jasmine."
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner January 26, 2023 16:31
@BenoitZugmeyer BenoitZugmeyer changed the title ✅ fix Jasmine deprecation warning on unit tests/IE ✅ fix Jasmine deprecation warning in unit tests/IE Jan 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1974 (bf013cc) into main (57d9e2a) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
+ Coverage   93.34%   93.43%   +0.09%     
==========================================
  Files         144      144              
  Lines        5482     5482              
  Branches     1246     1246              
==========================================
+ Hits         5117     5122       +5     
+ Misses        365      360       -5     
Impacted Files Coverage Δ
...ackages/rum-core/src/domain/waitPageActivityEnd.ts 100.00% <0.00%> (+1.53%) ⬆️
...rum-core/src/domain/contexts/foregroundContexts.ts 96.92% <0.00%> (+6.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BenoitZugmeyer BenoitZugmeyer merged commit 1ab2229 into main Jan 30, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/fix-jasmine-deprecation-warning branch January 30, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants