Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ fix Jasmine deprecation warning in unit tests/IE #1974

Merged
merged 1 commit into from
Jan 30, 2023
Merged

✅ fix Jasmine deprecation warning in unit tests/IE #1974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 51 additions & 56 deletions packages/rum-core/src/browser/htmlDomUtils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,48 +57,45 @@ describe('isElementNode', () => {
})
})

describe('isShadowRoot', () => {
if (isIE()) {
return
}

const parent = document.createElement('div')
parent.attachShadow({ mode: 'open' })
const parameters: Array<[Node, boolean]> = [
[parent.shadowRoot!, true],
[parent, false],
[document.body, false],
[document.createTextNode('hello'), false],
[document.createComment('hello'), false],
]
if (!isIE()) {
describe('isShadowRoot', () => {
const parent = document.createElement('div')
parent.attachShadow({ mode: 'open' })
const parameters: Array<[Node, boolean]> = [
[parent.shadowRoot!, true],
[parent, false],
[document.body, false],
[document.createTextNode('hello'), false],
[document.createComment('hello'), false],
]

parameters.forEach(([element, result]) => {
it(`should return ${String(result)} for "${String(element)}"`, () => {
expect(isNodeShadowRoot(element)).toBe(result)
parameters.forEach(([element, result]) => {
it(`should return ${String(result)} for "${String(element)}"`, () => {
expect(isNodeShadowRoot(element)).toBe(result)
})
})
})
})

describe('isShadowHost', () => {
if (isIE()) {
return
}
const host = document.createElement('div')
host.attachShadow({ mode: 'open' })
const parameters: Array<[Node, boolean]> = [
[host, true],
[host.shadowRoot!, false],
[document.body, false],
[document.createTextNode('hello'), false],
[document.createComment('hello'), false],
]
}

if (!isIE()) {
describe('isShadowHost', () => {
const host = document.createElement('div')
host.attachShadow({ mode: 'open' })
const parameters: Array<[Node, boolean]> = [
[host, true],
[host.shadowRoot!, false],
[document.body, false],
[document.createTextNode('hello'), false],
[document.createComment('hello'), false],
]

parameters.forEach(([element, result]) => {
it(`should return ${String(result)} for "${String(element)}"`, () => {
expect(isNodeShadowHost(element)).toBe(result)
parameters.forEach(([element, result]) => {
it(`should return ${String(result)} for "${String(element)}"`, () => {
expect(isNodeShadowHost(element)).toBe(result)
})
})
})
})
}

describe('getChildNodes', () => {
it('should return the direct children for a normal node', () => {
Expand Down Expand Up @@ -140,27 +137,25 @@ describe('getChildNodes', () => {
})
})

describe('getParentNode', () => {
if (isIE()) {
return
}

const orphanDiv = document.createElement('div')
const parentWithShadowRoot = document.createElement('div')
const shadowRoot = parentWithShadowRoot.attachShadow({ mode: 'open' })
if (!isIE()) {
describe('getParentNode', () => {
const orphanDiv = document.createElement('div')
const parentWithShadowRoot = document.createElement('div')
const shadowRoot = parentWithShadowRoot.attachShadow({ mode: 'open' })

const parentWithoutShadowRoot = document.createElement('div')
const child = document.createElement('span')
parentWithoutShadowRoot.appendChild(child)
const parentWithoutShadowRoot = document.createElement('div')
const child = document.createElement('span')
parentWithoutShadowRoot.appendChild(child)

const parameters: Array<[string, Node, Node | null]> = [
['return null if without parent', orphanDiv, null],
['return the host for a shadow root', shadowRoot, parentWithShadowRoot],
['return the parent for normal child', child, parentWithoutShadowRoot],
]
parameters.forEach(([label, element, result]) => {
it(`should ${label}`, () => {
expect(getParentNode(element)).toBe(result)
const parameters: Array<[string, Node, Node | null]> = [
['return null if without parent', orphanDiv, null],
['return the host for a shadow root', shadowRoot, parentWithShadowRoot],
['return the parent for normal child', child, parentWithoutShadowRoot],
]
parameters.forEach(([label, element, result]) => {
it(`should ${label}`, () => {
expect(getParentNode(element)).toBe(result)
})
})
})
})
}