✨ [RUM-2203] Forward replay records to the bridge #2470

amortemousque · 2023-10-18T15:23:17Z

Motivation

In order to support webviews for Session Replay, the Browser SDK needs to send Replay records through the event bridge.

Changes

Upgrade the bridge interface ( add getPrivacyLevel(), getCapabilities() and add event.id in the send() API)
Detect if the bridge supports sending records
Send Replay records through the bridge when it is present and the bridge supports records
Use the privacy level provided by the bridge when no default privacy level is passed in the init config

Testing

Local
Staging
Unit
End to end

I have gone over the contributing documentation.

codecov-commenter · 2023-10-19T14:57:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (b9ebe46) to head (63d4812).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2470      +/-   ##
==========================================
+ Coverage   92.86%   92.90%   +0.04%     
==========================================
  Files         237      238       +1     
  Lines        6885     6911      +26     
  Branches     1507     1516       +9     
==========================================
+ Hits         6394     6421      +27     
+ Misses        491      490       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Add getPrivacyLevel() - Send current view id

- If not provided in the init configuration use the bridge privacy level

amortemousque · 2024-01-23T09:22:33Z

/to-staging

dd-devflow · 2024-01-23T09:22:38Z

🚂 Branch Integration: starting soon, merge in < 0s

Commit b41dba25a5 will soon be integrated into staging-04.

This build is going to start soon! (estimated merge in less than 0s)

Use /to-staging -c to cancel this operation!

Co-authored-by: Aymeric Mortemousque <aymeric.mortemousque@datadoghq.com>

dd-devflow · 2024-01-23T09:31:04Z

🚂 Branch Integration: This commit was successfully integrated

Commit b41dba25a5 has been merged into staging-04 in merge commit 85492e9f00.

Check out the triggered pipeline on Gitlab 🦊

packages/logs/src/transport/startLogsBridge.ts

packages/rum/src/domain/startRecordBridge.ts

packages/rum-core/src/boot/rumPublicApi.spec.ts

packages/rum/src/boot/recorderApi.ts

packages/core/src/transport/eventBridge.spec.ts

packages/rum/src/boot/startRecording.ts

test/e2e/scenario/eventBridge.scenario.ts

test/e2e/lib/framework/serverApps/intake.ts

packages/rum/src/domain/startRecordBridge.ts

packages/rum/src/boot/startRecording.ts

test/e2e/scenario/eventBridge.scenario.ts

packages/core/src/transport/eventBridge.ts

bcaudan · 2024-02-26T09:19:47Z

/to-staging

dd-devflow · 2024-02-26T09:19:52Z

🚂 Branch Integration: starting soon, merge in < 0s

Commit 681baac5a4 will soon be integrated into staging-09.

This build is going to start soon! (estimated merge in less than 0s)

Use /to-staging -c to cancel this operation!

Co-authored-by: Aymeric Mortemousque <aymeric.mortemousque@datadoghq.com>

dd-devflow · 2024-02-26T09:30:13Z

🚂 Branch Integration: This commit was successfully integrated

Commit 681baac5a4 has been merged into staging-09 in merge commit 58a85353d3.

Check out the triggered pipeline on Gitlab 🦊

packages/rum-core/src/boot/preStartRum.spec.ts

bcaudan · 2024-03-05T09:19:57Z

packages/rum-core/src/domain/rumSessionManager.ts

@@ -65,7 +72,7 @@ export function startRumSessionManager(
 export function startRumSessionManagerStub(): RumSessionManager {
  const session: RumSession = {
    id: '00000000-aaaa-0000-aaaa-000000000000',
-    sessionReplayAllowed: false,
+    sessionReplayAllowed: bridgeSupports(BridgeCapability.RECORDS),


👏 praise: ‏nice!

amortemousque · 2024-03-05T10:13:32Z

/to-staging

dd-devflow · 2024-03-05T10:13:37Z

🚂 Branch Integration: starting soon, merge in < 9m

Commit 63d4812751 will soon be integrated into staging-10.

This build is going to start soon! (estimated merge in less than 9m)

Use /to-staging -c to cancel this operation!

Co-authored-by: Aymeric Mortemousque <aymeric.mortemousque@datadoghq.com>

dd-devflow · 2024-03-05T10:23:59Z

🚂 Branch Integration: This commit was successfully integrated

Commit 63d4812751 has been merged into staging-10 in merge commit b7b659139e.

Check out the triggered pipeline on Gitlab 🦊

amortemousque force-pushed the aymeric/webview-replay branch 2 times, most recently from f80261a to 7b13ec1 Compare October 19, 2023 14:54

BenoitZugmeyer force-pushed the aymeric/webview-replay branch 2 times, most recently from d86881d to 4e3ec9f Compare October 31, 2023 10:36

amortemousque force-pushed the aymeric/webview-replay branch 2 times, most recently from fd84c10 to 33526f4 Compare November 16, 2023 09:01

amortemousque force-pushed the aymeric/webview-replay branch from b93ed47 to 65e5af0 Compare January 15, 2024 10:23

BenoitZugmeyer force-pushed the aymeric/webview-replay branch from 65e5af0 to c878318 Compare January 19, 2024 13:55

amortemousque force-pushed the aymeric/webview-replay branch from c878318 to 12e30ab Compare January 22, 2024 09:28

amortemousque added 4 commits January 22, 2024 16:24

Update event bridge interface

7b40bbb

- Add getPrivacyLevel() - Send current view id

Send records through the bridge

d115652

Use the bridge privacy level

ac14252

- If not provided in the init configuration use the bridge privacy level

Add an e2e test

b41dba2

amortemousque force-pushed the aymeric/webview-replay branch from f2edae1 to b41dba2 Compare January 22, 2024 15:30

amortemousque marked this pull request as ready for review January 22, 2024 15:36

amortemousque requested review from a team as code owners January 22, 2024 15:36

amortemousque changed the title ~~[RUM-1596] Replay event bridge POC~~ [RUM-1596] Forward replay records to the bridge Jan 22, 2024

amortemousque changed the title ~~[RUM-1596] Forward replay records to the bridge~~ ✨ [RUM-2203] Forward replay records to the bridge Jan 22, 2024

dd-mergequeue bot added a commit that referenced this pull request Jan 23, 2024

Integrate b41dba2 (#2470) from aymeric/webview-replay into staging-04

85492e9

Co-authored-by: Aymeric Mortemousque <aymeric.mortemousque@datadoghq.com>

dd-devflow bot added the staging-04 label Jan 23, 2024

bcaudan reviewed Jan 24, 2024

View reviewed changes

BenoitZugmeyer reviewed Jan 24, 2024

View reviewed changes

packages/rum/src/boot/recorderApi.ts Outdated Show resolved Hide resolved

Fixes

e63a131

bcaudan reviewed Jan 24, 2024

View reviewed changes

Simplifications

9ae3e93

amortemousque force-pushed the aymeric/webview-replay branch from e05cc18 to 8df8521 Compare January 31, 2024 17:02

bcaudan reviewed Feb 1, 2024

View reviewed changes

test/e2e/lib/framework/serverApps/intake.ts Outdated Show resolved Hide resolved

packages/rum/src/domain/startRecordBridge.ts Show resolved Hide resolved

BenoitZugmeyer reviewed Feb 1, 2024

View reviewed changes

amortemousque added 3 commits February 1, 2024 15:13

nitpicks

354bc0f

Simplify e2e tests

7e5c7fe

test

52974bb

amortemousque force-pushed the aymeric/webview-replay branch from c975407 to 080d715 Compare February 19, 2024 13:47

Merge branch 'main' into aymeric/webview-replay

f77b6b4

amortemousque force-pushed the aymeric/webview-replay branch 5 times, most recently from a24daf4 to 1578088 Compare February 24, 2024 18:02

Add feature detection

681baac

amortemousque force-pushed the aymeric/webview-replay branch from 1578088 to 681baac Compare February 24, 2024 19:18

dd-mergequeue bot added a commit that referenced this pull request Feb 26, 2024

Integrate 681baac (#2470) from aymeric/webview-replay into staging-09

58a8535

Co-authored-by: Aymeric Mortemousque <aymeric.mortemousque@datadoghq.com>

dd-devflow bot added the staging-09 label Feb 26, 2024

BenoitZugmeyer approved these changes Mar 4, 2024

View reviewed changes

bcaudan approved these changes Mar 5, 2024

View reviewed changes

Add test

63d4812

dd-mergequeue bot added a commit that referenced this pull request Mar 5, 2024

Integrate 63d4812 (#2470) from aymeric/webview-replay into staging-10

b7b6591

Co-authored-by: Aymeric Mortemousque <aymeric.mortemousque@datadoghq.com>

dd-devflow bot added the staging-10 label Mar 5, 2024

amortemousque merged commit 09d890a into main Mar 5, 2024
18 checks passed

amortemousque deleted the aymeric/webview-replay branch March 5, 2024 12:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ [RUM-2203] Forward replay records to the bridge #2470

✨ [RUM-2203] Forward replay records to the bridge #2470

amortemousque commented Oct 18, 2023 •

edited

codecov-commenter commented Oct 19, 2023 •

edited

amortemousque commented Jan 23, 2024

dd-devflow bot commented Jan 23, 2024

dd-devflow bot commented Jan 23, 2024

bcaudan commented Feb 26, 2024

dd-devflow bot commented Feb 26, 2024

dd-devflow bot commented Feb 26, 2024

bcaudan Mar 5, 2024

amortemousque commented Mar 5, 2024

dd-devflow bot commented Mar 5, 2024

dd-devflow bot commented Mar 5, 2024

✨ [RUM-2203] Forward replay records to the bridge #2470

✨ [RUM-2203] Forward replay records to the bridge #2470

Conversation

amortemousque commented Oct 18, 2023 • edited

Motivation

Changes

Testing

codecov-commenter commented Oct 19, 2023 • edited

Codecov Report

amortemousque commented Jan 23, 2024

dd-devflow bot commented Jan 23, 2024

dd-devflow bot commented Jan 23, 2024

bcaudan commented Feb 26, 2024

dd-devflow bot commented Feb 26, 2024

dd-devflow bot commented Feb 26, 2024

bcaudan Mar 5, 2024

Choose a reason for hiding this comment

amortemousque commented Mar 5, 2024

dd-devflow bot commented Mar 5, 2024

dd-devflow bot commented Mar 5, 2024

amortemousque commented Oct 18, 2023 •

edited

codecov-commenter commented Oct 19, 2023 •

edited