Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUM-2203] Forward replay records to the bridge #2470

Merged
merged 17 commits into from Mar 5, 2024
Merged
21 changes: 19 additions & 2 deletions packages/rum-core/src/boot/rumPublicApi.spec.ts
Expand Up @@ -23,6 +23,7 @@ import {
deleteEventBridgeStub,
cleanupSyntheticsWorkerValues,
mockSyntheticsWorkerValues,
PRIVACY_LEVEL_FROM_EVENT_BRIDGE,
} from '@datadog/browser-core/test'
import type { TestSetupBuilder } from '../../test'
import { setup, noopRecorderApi } from '../../test'
Expand Down Expand Up @@ -112,18 +113,34 @@ describe('rum public api', () => {
deleteEventBridgeStub()
})

it('init should accept empty application id and client token', () => {
it('should accept empty application id and client token', () => {
const hybridInitConfiguration: HybridInitConfiguration = {}
rumPublicApi.init(hybridInitConfiguration as RumInitConfiguration)
expect(display.error).not.toHaveBeenCalled()
})

it('init should force session sample rate to 100', () => {
it('should force session sample rate to 100', () => {
const invalidConfiguration: HybridInitConfiguration = { sessionSampleRate: 50 }
rumPublicApi.init(invalidConfiguration as RumInitConfiguration)
expect(rumPublicApi.getInitConfiguration()?.sessionSampleRate).toEqual(100)
})

it('should set the default privacy level received from the bridge if the not provided in the init configuration', () => {
const hybridInitConfiguration: HybridInitConfiguration = {}
rumPublicApi.init(hybridInitConfiguration as RumInitConfiguration)
expect((rumPublicApi.getInitConfiguration() as RumInitConfiguration)?.defaultPrivacyLevel).toEqual(
PRIVACY_LEVEL_FROM_EVENT_BRIDGE
)
amortemousque marked this conversation as resolved.
Show resolved Hide resolved
})

it('should set the default privacy level from the init configuration if provided', () => {
const hybridInitConfiguration: HybridInitConfiguration = { defaultPrivacyLevel: 'mask' }
rumPublicApi.init(hybridInitConfiguration as RumInitConfiguration)
expect((rumPublicApi.getInitConfiguration() as RumInitConfiguration)?.defaultPrivacyLevel).toEqual(
hybridInitConfiguration.defaultPrivacyLevel
)
})

it('should initialize even if session cannot be handled', () => {
spyOnProperty(document, 'cookie', 'get').and.returnValue('')
const rumPublicApi = makeRumPublicApi(startRumSpy, noopRecorderApi, {})
Expand Down
4 changes: 3 additions & 1 deletion packages/rum-core/src/boot/rumPublicApi.ts
Expand Up @@ -31,6 +31,7 @@ import {
CustomerDataCompressionStatus,
createCustomerDataTrackerManager,
storeContextManager,
getEventBridge,
} from '@datadog/browser-core'
import type { LifeCycle } from '../domain/lifeCycle'
import type { ViewContexts } from '../domain/contexts/viewContexts'
Expand Down Expand Up @@ -341,11 +342,12 @@ export function makeRumPublicApi(
return true
}

function overrideInitConfigurationForBridge<C extends InitConfiguration>(initConfiguration: C): C {
function overrideInitConfigurationForBridge<C extends RumInitConfiguration>(initConfiguration: C): C {
return assign({}, initConfiguration, {
applicationId: '00000000-aaaa-0000-aaaa-000000000000',
clientToken: 'empty',
sessionSampleRate: 100,
defaultPrivacyLevel: initConfiguration.defaultPrivacyLevel ?? getEventBridge()?.getPrivacyLevel(),
})
}
}