New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [RUM-3039] Fix missing pending mutations at view end #2598
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2598 +/- ##
==========================================
+ Coverage 92.81% 92.96% +0.14%
==========================================
Files 236 236
Lines 6833 6850 +17
Branches 1499 1500 +1
==========================================
+ Hits 6342 6368 +26
+ Misses 491 482 -9 ☔ View full report in Codecov by Sentry. |
/to-staging |
🚂 Branch Integration: starting soon, merge in < 0s Commit b4330d4d71 will soon be integrated into staging-07. This build is going to start soon! (estimated merge in less than 0s) Use |
🚂 Branch Integration: This commit was successfully integrated Commit b4330d4d71 has been merged into staging-07 in merge commit 9a0cc04877. Check out the triggered pipeline on Gitlab 🦊 |
d5495d8
to
922b351
Compare
922b351
to
85f15e7
Compare
85f15e7
to
768b4a4
Compare
/to-staging |
🚂 Branch Integration: starting soon, merge in < 9m Commit 768b4a46fc will soon be integrated into staging-07. This build is going to start soon! (estimated merge in less than 9m) Use |
🚨 Branch Integration: The build pipeline contains failing jobs for this merge request We couldn't automatically merge the commit 768b4a46fc into staging-07. Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. You should have a look at the pipeline, wait for the build to finish and investigate the failures.
|
6eda70a
to
0914840
Compare
7fb59cf
to
551d175
Compare
Motivation
We are missing records generated during the
VIEW_END
lifecycle callbacks (if no segment is already created) because no view is active at that time:This PR introduce new
BEFORE_XXX
lifecycle events where the SDK contexts are still active allowing to send last pending recordsChanges
BEFORE_XXX
andAFTER_XXX
lifecycle events used by contexts to ensures the context is available during the non prefixed event callbacks.BEFORE_VIEW_CREATED
and close atAFTER_VIEW_ENDED
PAGE_EXITED
to prevent unexpected records after the view is closedscrollObserver
,moveObserver
andinstrumentSetter
Testing
I have gone over the contributing documentation.