Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[RUMF-617] integrate tracing (#461)" #499

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Aug 24, 2020

Motivation

setback in tracing strategy, in wait of a clearer strategy

Changes

reverts commit 5d7a689


I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner August 24, 2020 08:53
@codecov-commenter
Copy link

Codecov Report

Merging #499 into master will decrease coverage by 0.60%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   88.04%   87.44%   -0.61%     
==========================================
  Files          36       34       -2     
  Lines        2209     2111      -98     
  Branches      432      416      -16     
==========================================
- Hits         1945     1846      -99     
- Misses        264      265       +1     
Impacted Files Coverage Δ
packages/core/src/configuration.ts 83.33% <ø> (+2.89%) ⬆️
packages/rum/src/rum.ts 86.04% <ø> (-3.96%) ⬇️
packages/rum/src/requestCollection.ts 96.87% <93.75%> (-3.13%) ⬇️
packages/core/src/fetchProxy.ts 97.72% <100.00%> (-0.15%) ⬇️
packages/core/src/xhrProxy.ts 100.00% <100.00%> (ø)
packages/rum/src/rum.entry.ts 73.21% <100.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff82247...cf8c056. Read the comment docs.

@bcaudan bcaudan merged commit 9826e05 into master Aug 24, 2020
@bcaudan bcaudan deleted the bcaudan/revert-tracing branch August 24, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants