Switch to using cookstyle #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
reviewed
Oct 29, 2018
There was a problem hiding this comment.
Thanks @jeffbyrnes for this, makes perfect sense 👍
The Travis build seems to be failing (https://travis-ci.org/DataDog/chef-datadog/builds/439759521), would you happen to know why? (may be related to the old version of chefDK that we use there, and which only provides rubocop 0.49.1)
Maintain the current style choices, but does away with a lot of unnecessary rule bending/exclusion. Maintains backwards-compatible w/ ChefDK v2.x w/ the Style/TrailingCommaInLiteral rule. However, this rule breaks newer configurations, so it should eventually be removed.
jeffbyrnes
force-pushed
the
switch-to-cookstyle
branch
from
bb6e855
to
08b533b
Compare
|
@olivielpeau that is exactly what’s happening; turns out this rule was broken into two separate rules. I’ve added the old rule in, and updated the commit message to point out that having it in breaks running on newer versions of RuboCop/cookstyle: |
|
Awesome, thanks for the quick fix! Merging this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintain the current style choices, but does away with a lot of unnecessary rule bending/exclusion.