Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] Add ARM integration tests for the lambda extension #11091

Merged
merged 38 commits into from
Mar 7, 2022

Conversation

thedavlee
Copy link

@thedavlee thedavlee commented Feb 28, 2022

What does this PR do?

Adds integration tests covering the ARM lambda extension. This modifies the existing serverless github workflow to run the arm tests in parallel.

  • Existing amd64 integration test snapshots were not modified, only changed location

Motivation

Adding ARM coverage for the extension will help us catch potentially missed bugs in the future.

Additional Notes

The log-csharp integration test would commonly fail with the error:

LAMBDA_RUNTIME Failed to get next invocation. No Response from endpoint
"message": "An error occurred while attempting to execute your code.: LambdaException",
"message": "terminate called after throwing an instance of 'std::logic_error'"
"message": "what():  basic_string::_M_construct null not valid"
  • Other non log csharp tests filter out this error, so it only appears in log-csharp
  • This is an issue with the lambda extension doing work when a SHUTDOWN event is received (in the allowed two seconds), and looks like an issue on the AWS side. We will ignore the error for now.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • The appropriate team/.. label has been applied, if known.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@bits-bot
Copy link
Collaborator

bits-bot commented Feb 28, 2022

CLA assistant check
All committers have signed the CLA.

@thedavlee thedavlee marked this pull request as ready for review February 28, 2022 17:52
fi

dotnet lambda package --configuration Release --framework netcoreapp3.1 --verbosity quiet --output-package bin/Release/netcoreapp3.1/handler.zip --function-architecture $CONVERTED_ARCH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@@ -24,27 +24,38 @@ provider:
DD_SERVICE: integration-tests-service
DD_TAGS: tagA:valueA tagB:valueB
DD_EXTRA_TAGS: tagC:valueC tagD:valueD
DD_ARCHITECTURE: ${env:ARCHITECTURE}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this env var do?

Copy link
Author

@thedavlee thedavlee Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a remnant from some debugging oops, let me remove that

@thedavlee thedavlee merged commit 6347a7e into main Mar 7, 2022
@thedavlee thedavlee deleted the david.lee/add-arm-integration-tests-lambda-extension branch March 7, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants