-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serverless] Add ARM integration tests for the lambda extension #11091
[Serverless] Add ARM integration tests for the lambda extension #11091
Conversation
…gs in multiple handlers
fi | ||
|
||
dotnet lambda package --configuration Release --framework netcoreapp3.1 --verbosity quiet --output-package bin/Release/netcoreapp3.1/handler.zip --function-architecture $CONVERTED_ARCH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
@@ -24,27 +24,38 @@ provider: | |||
DD_SERVICE: integration-tests-service | |||
DD_TAGS: tagA:valueA tagB:valueB | |||
DD_EXTRA_TAGS: tagC:valueC tagD:valueD | |||
DD_ARCHITECTURE: ${env:ARCHITECTURE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this env var do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a remnant from some debugging oops, let me remove that
What does this PR do?
Adds integration tests covering the ARM lambda extension. This modifies the existing serverless github workflow to run the arm tests in parallel.
Motivation
Adding ARM coverage for the extension will help us catch potentially missed bugs in the future.
Additional Notes
The log-csharp integration test would commonly fail with the error:
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.team/..
label has been applied, if known.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.need-change/operator
andneed-change/helm
labels have been applied.