[serverless] Configure logs/core agent to respect datadog.yaml #11269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a test to make sure the issue does not re-occur? |
I'm going to add a datadog.yaml to an integration test, with log obfuscation enabled. I think that will be the best way to test it. |
nhinsch
reviewed
Mar 18, 2022
| @@ -9,7 +9,8 @@ async function myHandler(event, context) { | |||
| await sleep(); | |||
| console.error("XXX LOG 2 XXX"); | |||
| await sleep(); | |||
|
|
|||
| console.error("XXX LOG M12345M XXX"); | |||
There was a problem hiding this comment.
I would suggest replacing M12345M with something like IF THIS STRING APPEARS IN A SNAPSHOT, MASKING IS NOT WORKING so that it's easier to see in a diff what the expected behavior is.
nhinsch
approved these changes
Mar 18, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug in the Datadog Lambda Extension, that was causing datadog.yaml to be incorrectly loaded.
Motivation
It appears this code was refactored out by mistake:
11e6514#diff-80867e42400e0fcf41760721c1e7bf703a1064d0636bfe72007834f0f21f7475L219
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.