Change Error log to Warn when SyncForwarder fails to send #11364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhinsch
added
changelog/no-changelog
[deprecated] qa/skip-qa - use other qa/ labels
nhinsch
changed the title
maxday
approved these changes
Mar 18, 2022
remeh
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the log level when the SyncForwarder fails to send a transaction from an error to a warning.
Motivation
Currently, the SyncForwarder is only used by the Serverless agent (aka Lambda Extension). Error logs can cause a Lambda invocation to be flagged as failed in the Datadog UI. However, we do expect occasional networking issues/HTTP errors when sending telemetry to Datadog. To reduce customer confusion/alarm, we should downgrade the severity of this log message from
errortowarn.Reviewer's Checklist
Triagemilestone is set.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.