[serverless] Update integration tests for sls v3, tiered compilation #11383
Conversation
nhinsch
added
changelog/no-changelog
[deprecated] qa/skip-qa - use other qa/ labels
| @@ -167,7 +167,7 @@ functions_to_skip=( | |||
| echo "Invoking functions for the first time..." | |||
| set +e # Don't exit this script if an invocation fails or there's a diff | |||
| for function_name in "${all_functions[@]}"; do | |||
| serverless invoke --stage "${stage}" -f "${function_name}" >/dev/null & | |||
| serverless invoke --stage "${stage}" -f "${function_name}" &>/dev/null & | |||
There was a problem hiding this comment.
is this required? maybe it's better to not silent all errors?
There was a problem hiding this comment.
I added this because the Serverless Framework v3 seems to log some stuff to STDERR even when it successfully invokes functions, creating a bunch of noise. I'll look into this more and see if there is some way I can resolve it without silencing legitimate errors.
There was a problem hiding this comment.
I investigated this more -- I think we do want to hide the output here, because errors are normal when invoking these test functions. Some of the test functions are designed to intentionally throw errors or time out. If we don't hide the output here, it's quite confusing because it looks like something is going badly wrong with the tests when in fact everything is fine. With Serverless v3, we do need to suppress STDERR in addition to STDOUT to achieve this effect.
What does this PR do?
Additional Notes
This PR should not be merged until the corresponding datadog-lambda-extension PR is merged.
Reviewer's Checklist
Triagemilestone is set.changelog/no-changeloglabel has been applied.team/..label has been applied, indicating the team(s) that should QA this change.