Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] Remove cobra dependency #11390

Merged
merged 1 commit into from
Mar 22, 2022
Merged

[Serverless] Remove cobra dependency #11390

merged 1 commit into from
Mar 22, 2022

Conversation

maxday
Copy link
Contributor

@maxday maxday commented Mar 21, 2022

What does this PR do?

I think we can get rid of Cobra as we never use the extension as a CLI + get the version
The version is logged when the extension is starting

This PR also removes imports from expvar and net/http/pprof as we do not use them

Motivation

Cleanup

Describe how to test/QA your changes

integration tests to make sure that the extension keeps starting

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@maxday maxday added this to the Triage milestone Mar 21, 2022
@maxday maxday requested a review from a team as a code owner March 21, 2022 19:48
Copy link
Contributor

@nhinsch nhinsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@maxday maxday merged commit 0735555 into main Mar 22, 2022
@maxday maxday deleted the maxday/remove-cobra branch March 22, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants