Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of go4.org/unsafe/assume-no-moving-gc for GO 1.18 #11455

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Mar 25, 2022

What does this PR do?

Bump the version of the go4.org/unsafe/assume-no-moving-gc dependency in order to get this patch: go4org/unsafe-assume-no-moving-gc#4.

Motivation

If the agent is currently built with GO 1.18, it panics at startup with this error:

panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.18 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.18 set. Notably, if go1.18 adds a moving garbage collector, this program is unsafe to use.

goroutine 1 [running]:
go4.org/unsafe/assume-no-moving-gc.init.0()
	/home/lenaic/go/pkg/mod/go4.org/unsafe/assume-no-moving-gc@v0.0.0-20201222175341-b30ae309168e/untested.go:24 +0x3a5

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@L3n41c L3n41c added team/containers changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card dependencies-go PRs that bump a go dependency labels Mar 25, 2022
@L3n41c L3n41c added this to the 7.36.0 milestone Mar 25, 2022
@L3n41c L3n41c merged commit cfd5473 into main Mar 25, 2022
@L3n41c L3n41c deleted the lenaic/go1.18 branch March 25, 2022 17:45
actionshrimp added a commit to actionshrimp/nixpkgs that referenced this pull request Dec 9, 2022
If using go119, the agent throws an error at startup:

```
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.19 runtime
```

I believe this needs a fix in the datadog package itself, similar to:
DataDog/datadog-agent#11455 but for go1.19
github-actions bot pushed a commit to NixOS/nixpkgs that referenced this pull request Dec 31, 2022
If using go119, the agent throws an error at startup:

```
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.19 runtime
```

I believe this needs a fix in the datadog package itself, similar to:
DataDog/datadog-agent#11455 but for go1.19

(cherry picked from commit 5727fbe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies-go PRs that bump a go dependency [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card team/containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants