[Serverless] support lambda direct invocation trace propagation #11624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedavlee
force-pushed
the
david.lee/lambda-extension-direct-invoke-trace-support
branch
from
1b5cfb1
to
6b5b50e
Compare
thedavlee
force-pushed
the
david.lee/lambda-extension-direct-invoke-trace-support
branch
from
6b5b50e
to
a58333a
Compare
thedavlee
changed the title
thedavlee
added
the
[deprecated] qa/skip-qa - use other qa/ labels
|
The associated change in |
maxday
reviewed
Apr 18, 2022
| var traceID, parentID uint64 | ||
| var e1, e2 error | ||
|
|
||
| if payload.Headers != nil { |
There was a problem hiding this comment.
this is checked twice, maybe you could find a way to refactor?
There was a problem hiding this comment.
I refactored this bit of code, let me know if it looks good!
thedavlee
deleted the
david.lee/lambda-extension-direct-invoke-trace-support
branch
maxday
added a commit
that referenced
this pull request
Apr 27, 2022
* [serverless] Share snapshots between integration tests (#11630) * [Serverless] added capture lambda payloads (#11484) Added the capture lambda payloads feature for universal instrumentation * [Serverless] support lambda direct invocation trace propagation (#11624) * support receiving directly invoked lambda trace context (universal instrumentation) Co-authored-by: Nicolas Hinsch <nick.hinsch@datadoghq.com> Co-authored-by: David Lee <david.lee@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for recieving lambda direct invocation trace context for trace propagation and merging, as a part of universal instrumentation
Motivation
Step towards universal instrumentation. Coupled with this dotnet tracer PR, we will support trace propagation/merging when an instrumented python/node lambda directly invokes a dotnet lambda synchronously using the AWS SDK
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Tested manually using the lambda-extension-dotnet lambda stack within the cloud-integrations repo, including testing with void, one param, two param, and invalid three param dotnet lambdas. Also tested changes with the current dotnet tracer version that doesnt support this feature.
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.