The Collector™ #148
Merged
The Collector™ #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
reviewed
Feb 13, 2017
pkg/collector/collector.go
Outdated
| } | ||
|
|
||
| // do we know this check instance? | ||
| if _, found := c.checks[id]; !found { |
There was a problem hiding this comment.
maybe should we not exist but just create the new check instead even if i wasn't running before ?
There was a problem hiding this comment.
So this is tricky b/c we could but at the moment we can't easily because the Loaders (that we need to try to create the right type of check) expect a different configuration format. But yeah, we should make checks creation simpler and take this into consideration, will add a TODO for now
hkaj
reviewed
Feb 13, 2017
| } | ||
|
|
||
| // ReloadCheck stops and restart a check with a new configuration | ||
| func (c *Collector) ReloadCheck(id check.ID, config, initConfig check.ConfigData) error { |
There was a problem hiding this comment.
can we extract a StopCheck(id check.ID) method from this? Service discovery will need it
masci
force-pushed
the
massi/collector
branch
from
b958000
to
6866369
Compare
masci
force-pushed
the
massi/collector
branch
from
ad40c74
to
3925be0
Compare
hush-hush
approved these changes
Feb 20, 2017
Kyle-Verhoog
pushed a commit
that referenced
this pull request
Jan 13, 2023
Add `ports` options to all Agent containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new component called
Collectorthat wraps the common operations needed to start collecting data from checks. TheCollectorbeside wrapping some code is responsible to keep the list of "active" check instances.To simplify the code and the API,
scheduler.Cancelandrunner.StopCheckwere made noops in case the check is not there.Motivation
Having a clean and consistent API to interact with check instances, something the Service Discovery will heavily rely on.