Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects internal_profiling.profile_dd_url config registration #16085

Merged
merged 1 commit into from Mar 15, 2023

Conversation

scottopell
Copy link
Contributor

What does this PR do?

Fixes the way the config option internal_profiling.profile_dd_url is registered with configuration.

This config option (intentionally) does not set a default value, therefore the second argument to BindEnv was being treated as the name of the chose environment variable for this config option. In effect, the env var for this config option was "" (the empty string).

This makes it impossible to set this config option via environment variable.

Motivation

Was getting error when trying to set this config option via env var:

2023-03-13 18:31:13 EDT | CORE | WARN | (pkg/util/log/log.go:618 in func1) | Unknown environment variable: DD_INTERNAL_PROFILING_PROFILE_DD_URL

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

N/A

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@scottopell scottopell added changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card team/agent-metrics-logs bugfix/functional labels Mar 13, 2023
@scottopell scottopell added this to the 7.45.0 milestone Mar 13, 2023
@scottopell scottopell requested a review from a team as a code owner March 13, 2023 22:46
@scottopell scottopell merged commit 7c056e8 into main Mar 15, 2023
12 checks passed
@scottopell scottopell deleted the fix/agent-internal-profiling branch March 15, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants