Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless][SLS-3279] Add back filtering for serverless span #16240

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

DylanLovesCoffee
Copy link
Contributor

What does this PR do?

Adds back an accidental removal of the filtering logic for the Serverless span sent by DD Trace when using universal instrumentation. Also added a unit test to catch this case.

Motivation

Pointed out to us in #serverless

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@DylanLovesCoffee DylanLovesCoffee added kind/bug changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card team/serverless labels Mar 22, 2023
@DylanLovesCoffee DylanLovesCoffee requested a review from a team as a code owner March 22, 2023 17:12
@DylanLovesCoffee DylanLovesCoffee added this to the Triage milestone Mar 22, 2023
@purple4reina purple4reina merged commit feb1a49 into main Mar 22, 2023
@purple4reina purple4reina deleted the dylan/fix-sls-span-filter branch March 22, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card kind/bug team/serverless
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants