Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch for pydantic-core in order to build successfully on CentOS 6 #18303

Merged
merged 20 commits into from
Jul 28, 2023

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jul 21, 2023

Motivation

Fix Pydantic v2 build errors

Requires DataDog/datadog-agent-buildimages#420

@pr-commenter
Copy link

pr-commenter bot commented Jul 21, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 748e3006-5566-40b7-9495-ff48e0e0454b
Baseline: 569df78
Comparison: 6041017
Total datadog-agent CPUs: 7

Explanation

A regression test is an integrated performance test for datadog-agent in a repeatable rig, with varying configuration for datadog-agent. What follows is a statistical summary of a brief datadog-agent run for each configuration across SHAs given above. The goal of these tests are to determine quickly if datadog-agent performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
tcp_syslog_to_blackhole ingress throughput +0.65 [+0.59, +0.71] 100.00%
trace_agent_json ingress throughput +0.04 [+0.02, +0.05] 98.39%
otel_to_otel_logs ingress throughput +0.02 [-0.04, +0.09] 36.53%
file_to_blackhole egress throughput +0.00 [-1.45, +1.46] 0.07%
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.06, +0.05] 9.12%
trace_agent_msgpack ingress throughput -0.06 [-0.09, -0.04] 99.98%
uds_dogstatsd_to_api ingress throughput -0.62 [-1.21, -0.03] 82.39%

@ofek ofek force-pushed the ofek/rust-old-glibc branch 4 times, most recently from 2358c80 to 07462e4 Compare July 24, 2023 21:46
@ofek ofek changed the title Target MUSL when building Rust projects on CentOS 6 Add patch for pydantic-core in order to build successfully on CentOS 6 Jul 25, 2023
@FlorentClarret FlorentClarret removed the request for review from a team July 27, 2023 06:20
@ofek ofek force-pushed the ofek/rust-old-glibc branch 3 times, most recently from e8765c9 to ff2a403 Compare July 27, 2023 20:39
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@FlorentClarret FlorentClarret merged commit 0d95563 into main Jul 28, 2023
112 of 131 checks passed
@FlorentClarret FlorentClarret deleted the ofek/rust-old-glibc branch July 28, 2023 07:45
julesmcrt pushed a commit that referenced this pull request Jul 28, 2023
#18303)

* Target MUSL when building Rust projects on CentOS 6

* update -core branch

* build pydantic-core from source

* trigger

* Update pydantic-core-build-for-manylinux1.patch

* upgrade

* Update pydantic-core-build-for-manylinux1.patch

* Update pydantic-core-build-for-manylinux1.patch

* Update pydantic-core-build-for-manylinux1.patch

* Update pydantic-core-build-for-manylinux1.patch

* Update pydantic-core-build-for-manylinux1.patch

* Update pydantic-core-build-for-manylinux1.patch

* Update pydantic-core-build-for-manylinux1.patch

* finish

* nit

* Revert "update -core branch"

This reverts commit 0af51e0.

* exclude arm

* exclude arm

* Update .gitlab-ci.yml

* Update .gitlab-ci.yml

---------

Co-authored-by: Florent Clarret <florent.clarret@datadoghq.com>
chouquette added a commit that referenced this pull request Mar 5, 2024
chouquette added a commit that referenced this pull request Mar 5, 2024
chouquette added a commit that referenced this pull request Mar 5, 2024
chouquette added a commit that referenced this pull request Mar 5, 2024
chouquette added a commit that referenced this pull request Mar 6, 2024
chouquette added a commit that referenced this pull request Mar 6, 2024
chouquette added a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants