Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): Use gcr.io by default instead of public.ecr.aws #25362

Merged
merged 1 commit into from
May 6, 2024

Conversation

BaptisteFoy
Copy link
Contributor

What does this PR do?

Merge #25255 back in main

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@BaptisteFoy BaptisteFoy added changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/fleet-automation labels May 6, 2024
@BaptisteFoy BaptisteFoy marked this pull request as ready for review May 6, 2024 13:02
@BaptisteFoy BaptisteFoy requested a review from a team as a code owner May 6, 2024 13:02
@BaptisteFoy
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 6, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@pr-commenter
Copy link

pr-commenter bot commented May 6, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=33654029 --os-family=ubuntu

@dd-devflow
Copy link

dd-devflow bot commented May 6, 2024

🚂 MergeQueue

Pull request added to the queue.

There are 3 builds ahead! (estimated merge in less than 2h)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 2f1c2eb into main May 6, 2024
227 of 228 checks passed
@dd-mergequeue dd-mergequeue bot deleted the baptiste.foy/FA/installer-gcr-default--main branch May 6, 2024 15:03
@github-actions github-actions bot added this to the 7.55.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants