fix(TestCPU): Mark as flake in the flakes.yaml

[chouetz]

What does this PR do?

Mark the TestCPU as flake in the file rather in the code not to impact other test suites using it

Motivation

Prevent masking tests that currently work

Additional Notes

Added also the cpu test according to the message raised in this job

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[L3n41c]

I would have two questions:

• Is it needed to recursively list all the parents of a flaky test ? Ideally, I’d love to list only the “real flaky” one TestEKSSuite/TestCPU/metric___container.cpu.usage{^kube_deployment:stress-ng$,^kube_namespace:workload-cpustress$} and not all its parents.
  If we accept that a failing sub-test makes its parents fail, should that be taken into account by the framework reading flakes.yaml ?

• Does flakes.yaml support patterns ?
  TestCPU is executed inside two suites: TestEKSSuite and TestKindSuite.

Suggested change

	test/new-e2e/tests/containers:
	- TestEKSSuite/TestCPU/metric___container.cpu.usage{^kube_deployment:stress-ng$,^kube_namespace:workload-cpustress$}
	- TestEKSSuite/TestCPU
	- TestEKSSuite
	test/new-e2e/tests/containers:
	- Test(EKS|Kind)Suite/TestCPU/metric___container.cpu.usage{^kube_deployment:stress-ng$,^kube_namespace:workload-cpustress$}

[chouetz]

As discussed,

• we must list everything now pending a fix in the testwasher. This should not be needed anymore once this is merged
• we don't support regex now. It might be an improvement, quoting @KevinFairise2 here for information

[AliDatadog]

Could we keep a code comment here to notify that it's flaky ?

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 34133220 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

[chouetz]

/merge

[dd-devflow]

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=34133220 --os-family=ubuntu

[dd-devflow]

🚂 MergeQueue

Pull request added to the queue.

There are 3 builds ahead! (estimated merge in less than 2h)

Use /merge -c to cancel this operation!

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: c2dbce37-f9c4-4015-9a22-c785fc6baee6
Baseline: ac80dd7
Comparison: 8e43c2a

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
✅	file_to_blackhole	% cpu utilization	-27.53	[-32.11, -22.95]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	pycheck_1000_100byte_tags	% cpu utilization	+1.16	[-3.52, +5.83]
➖	idle	memory utilization	+0.32	[+0.28, +0.37]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.20, +0.20]
➖	trace_agent_json	ingress throughput	+0.00	[-0.01, +0.01]
➖	trace_agent_msgpack	ingress throughput	-0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.02	[-0.07, +0.03]
➖	otel_to_otel_logs	ingress throughput	-0.10	[-0.45, +0.26]
➖	basic_py_check	% cpu utilization	-0.43	[-3.02, +2.17]
➖	file_tree	memory utilization	-0.74	[-0.87, -0.61]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.08	[-3.95, +1.78]
➖	tcp_syslog_to_blackhole	ingress throughput	-11.15	[-31.27, +8.97]
✅	file_to_blackhole	% cpu utilization	-27.53	[-32.11, -22.95]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".