[OASIS-12] Allow serializerexporter to consume APM stats #26568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
added
changelog/no-changelog
team/opentelemetry
songy23
commented
Jun 10, 2024
| // The DD Connector doesn't set the agent version, so we'll set it here | ||
| sp.AgentVersion = agentVersion | ||
|
|
||
| // TODO(OASIS-12): send StatsPayload with trace agent |
songy23
commented
Jun 10, 2024
| @@ -180,6 +189,38 @@ func (f *factory) createMetricsExporter( | |||
| return sf.CreateMetricsExporter(ctx, set, ex) | |||
| } | |||
|
|
|||
| func (f *factory) consumeStatsPayload(ctx context.Context, wg *sync.WaitGroup, statsIn <-chan []byte, tracerVersion string, agentVersion string, logger *zap.Logger) { | |||
There was a problem hiding this comment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26568 +/- ##
===========================================
+ Coverage 44.86% 50.01% +5.14%
===========================================
Files 2354 337 -2017
Lines 273093 28262 -244831
===========================================
- Hits 122532 14134 -108398
+ Misses 140887 13388 -127499
+ Partials 9674 740 -8934
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=36326688 --os-family=ubuntu |
dineshg13
approved these changes
Jun 10, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add stats in channel to serializerexporter to consume APM stats
Split from #25759
Motivation
Consume and send APM stats from DD connector.
Describe how to test/QA your changes
n/a will be covered in #25759