Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datadog static analyzer #26627

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Add datadog static analyzer #26627

merged 4 commits into from
Jun 12, 2024

Conversation

juli1
Copy link
Contributor

@juli1 juli1 commented Jun 11, 2024

What does this PR do?

This PR adds supports for Datadog static analysis. It only checks rules that validates the GitHub actions are safe and secure.

Motivation

We want to ensure our GitHub actions are safe and secure.

@juli1 juli1 requested a review from a team as a code owner June 11, 2024 21:04
@bits-bot
Copy link
Collaborator

bits-bot commented Jun 11, 2024

CLA assistant check
All committers have signed the CLA.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 11, 2024

[Fast Unit Tests Report]

On pipeline 36515483 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@pr-commenter
Copy link

pr-commenter bot commented Jun 11, 2024

Regression Detector

Regression Detector Results

Run ID: bffba021-287d-40d9-8ef9-fe66721847b2
Baseline: c055910
Comparison: c9ee098

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +10.22 [-12.19, +32.63]
file_tree memory utilization +0.53 [+0.42, +0.63]
uds_dogstatsd_to_api_cpu % cpu utilization +0.32 [-2.70, +3.35]
pycheck_1000_100byte_tags % cpu utilization +0.19 [-4.59, +4.98]
tcp_dd_logs_filter_exclude ingress throughput +0.02 [-0.03, +0.06]
trace_agent_json ingress throughput +0.02 [-0.01, +0.04]
trace_agent_msgpack ingress throughput +0.02 [+0.01, +0.02]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
otel_to_otel_logs ingress throughput -0.19 [-0.56, +0.18]
idle memory utilization -0.23 [-0.28, -0.19]
basic_py_check % cpu utilization -1.06 [-4.06, +1.94]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

.github/workflows/datadog-static-analysis.yml Outdated Show resolved Hide resolved
juli1 and others added 3 commits June 12, 2024 15:09
Co-authored-by: Nicolas Schweitzer <nicolas.schweitzer@datadoghq.com>
@chouetz chouetz added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code labels Jun 12, 2024
@chouetz
Copy link
Contributor

chouetz commented Jun 12, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 12, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Jun 12, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 35m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit a62cefe into main Jun 12, 2024
213 of 215 checks passed
@dd-mergequeue dd-mergequeue bot deleted the juli1/add-static-analysis branch June 12, 2024 14:56
@github-actions github-actions bot added this to the 7.56.0 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-ci-experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants