Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Host name resolution #26985

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Remote Host name resolution #26985

merged 6 commits into from
Jun 24, 2024

Conversation

dineshg13
Copy link
Member

@dineshg13 dineshg13 commented Jun 23, 2024

What does this PR do?

Adds a remote host name resolution component.

Motivation

We need to get hostname from core agent in OTel Agent. Moving remote host resolution to an independent module

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@dineshg13 dineshg13 added this to the 7.56.0 milestone Jun 23, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 37385994 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_flavor_dogstatsd_deb-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@dineshg13 dineshg13 changed the title Dinesh.gurumurthy/oasis 55 Remote Host name resolution Jun 23, 2024
@dineshg13 dineshg13 marked this pull request as ready for review June 23, 2024 19:10
@dineshg13 dineshg13 requested review from a team as code owners June 23, 2024 19:10
@dineshg13 dineshg13 requested a review from songy23 June 23, 2024 19:10
@pr-commenter
Copy link

pr-commenter bot commented Jun 23, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=37385994 --os-family=ubuntu

Note: This applies to commit 6453865

@pr-commenter
Copy link

pr-commenter bot commented Jun 23, 2024

Regression Detector

Regression Detector Results

Run ID: e39fd928-893c-4523-bc5a-fdf5a5febe50 Metrics dashboard Target profiles

Baseline: 6a6c459
Comparison: 6453865

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
idle memory utilization +0.87 [+0.83, +0.90] Logs
basic_py_check % cpu utilization +0.72 [-1.88, +3.31] Logs
file_tree memory utilization +0.53 [+0.49, +0.58] Logs
otel_to_otel_logs ingress throughput +0.07 [-0.74, +0.88] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs
tcp_syslog_to_blackhole ingress throughput -1.42 [-13.98, +11.14] Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.82 [-2.71, -0.94] Logs
pycheck_1000_100byte_tags % cpu utilization -1.99 [-6.72, +2.74] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but added a comment about the potential need to override certain defaults. If you don't think it's necessary, I'm OK with that, or if you'd rather tackle that in follow-up work, that's also fine.

)

const (
defaultExpire = 15 * time.Minute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these values are defaults but cannot be overridden, should these be configurable? Same goes for maxAttempts. That would mean, of course, we'd need a dependency with the configuration component.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not to add configuration for this. Customers should worry about it. I don't think it currently configurable in any agent

@dineshg13
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 24, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Jun 24, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 26m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 6ca5917 into main Jun 24, 2024
225 of 226 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dinesh.gurumurthy/OASIS-55 branch June 24, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants