Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCII-1931] Close auth_token file in test to avoid error when deleting it #27140

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

pgimalac
Copy link
Contributor

What does this PR do?

Close the auth_token file in a test to avoid errors when deleting it.

Motivation

Not having errors.

Additional Notes

The test was added in #27129, it seems that it consistently passes on retries so the CI didn't complain, but it should succeed in one try.

Also updated the test to avoid using a tempdir since we only need a single file.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@pgimalac pgimalac added changelog/no-changelog team/agent-shared-components qa/no-code-change Skip QA week as there is no code change in Agent code labels Jun 28, 2024
@pgimalac pgimalac requested a review from a team as a code owner June 28, 2024 07:27
@pr-commenter
Copy link

pr-commenter bot commented Jun 28, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=37819340 --os-family=ubuntu

Note: This applies to commit 9891d60

@pgimalac
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 28, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 24m.

Use /merge -c to cancel this operation!

@pr-commenter
Copy link

pr-commenter bot commented Jun 28, 2024

Regression Detector

Regression Detector Results

Run ID: b1fd64df-0315-4be8-a5dc-a87b355d4455 Metrics dashboard Target profiles

Baseline: 1987bff
Comparison: 9891d60

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
file_tree memory utilization +1.58 [+1.44, +1.72] Logs
idle memory utilization +0.66 [+0.62, +0.71] Logs
otel_to_otel_logs ingress throughput +0.13 [-0.68, +0.94] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.85 [-1.74, +0.04] Logs
basic_py_check % cpu utilization -1.11 [-3.77, +1.55] Logs
pycheck_1000_100byte_tags % cpu utilization -2.07 [-6.90, +2.76] Logs
tcp_syslog_to_blackhole ingress throughput -3.18 [-15.58, +9.23] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@dd-mergequeue dd-mergequeue bot merged commit 3945ba0 into main Jun 28, 2024
236 of 244 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pgimalac/fix-servers-flake-close-file branch June 28, 2024 08:51
@github-actions github-actions bot added this to the 7.56.0 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants