Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.55.3 final PR #28136

Merged
merged 2 commits into from
Aug 1, 2024
Merged

7.55.3 final PR #28136

merged 2 commits into from
Aug 1, 2024

Conversation

Pythyu
Copy link
Contributor

@Pythyu Pythyu commented Aug 1, 2024

What does this PR do?

7.55.3 final PR

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@Pythyu Pythyu added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code labels Aug 1, 2024
@Pythyu Pythyu requested review from a team as code owners August 1, 2024 18:12
@Pythyu Pythyu requested review from mx-psi and removed request for a team August 1, 2024 18:12
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.93%. Comparing base (2fffda3) to head (42a547a).

Additional details and impacted files
@@            Coverage Diff             @@
##           7.55.x   #28136      +/-   ##
==========================================
- Coverage   44.93%   44.93%   -0.01%     
==========================================
  Files        2354     2354              
  Lines      272910   272910              
==========================================
- Hits       122643   122642       -1     
  Misses     140591   140591              
- Partials     9676     9677       +1     
Flag Coverage Δ
amzn_aarch64 45.78% <ø> (-0.01%) ⬇️
centos_x86_64 45.69% <ø> (-0.01%) ⬇️
ubuntu_aarch64 45.78% <ø> (-0.01%) ⬇️
ubuntu_x86_64 45.77% <ø> (-0.01%) ⬇️
windows_amd64 50.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Aug 1, 2024

Regression Detector

Regression Detector Results

Run ID: 6a455bcc-83b2-416a-8379-9b7188427e41

Baseline: 2fffda3
Comparison: 42a547a

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
pycheck_1000_100byte_tags % cpu utilization +0.36 [-4.44, +5.17]
idle memory utilization +0.26 [+0.23, +0.29]
basic_py_check % cpu utilization +0.12 [-2.50, +2.74]
file_tree memory utilization +0.08 [-0.00, +0.16]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
trace_agent_json ingress throughput -0.01 [-0.04, +0.02]
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.07, +0.03]
otel_to_otel_logs ingress throughput -0.04 [-0.39, +0.32]
tcp_syslog_to_blackhole ingress throughput -0.16 [-21.56, +21.24]
uds_dogstatsd_to_api_cpu % cpu utilization -1.25 [-4.06, +1.57]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relnote lgtm

@Pythyu Pythyu merged commit 89afbb0 into 7.55.x Aug 1, 2024
377 of 380 checks passed
@Pythyu Pythyu deleted the 7.55.3-final branch August 1, 2024 23:58
@github-actions github-actions bot added this to the 7.55.0 milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/no-code-change Skip QA week as there is no code change in Agent code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants