pkg/trace/api: ensure listener gets closed only once #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJF
reviewed
Apr 9, 2019
This change fixes a non-critical panic which was occurring with go1.10. In some situations, Close would get called multiple times on the listener when exiting the trace-agent. For details, see golang/go#24803
AlexJF
approved these changes
Apr 9, 2019
gbbr
added a commit
that referenced
this pull request
Apr 9, 2019
* pkg/trace/api: ensure listener gets closed only once This change fixes a non-critical panic which was occurring with go1.10. In some situations, Close would get called multiple times on the listener when exiting the trace-agent. For details, see golang/go#24803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a non-critical panic which was occurring with go1.10.
In some situations,
Closewould get called multiple times on thelistener when exiting the trace-agent. This was a bug in the
net/httppackage.
For our releases, we use go1.11 where this problem doesn't exist, but better
avoid it if we can.
For details, see golang/go#24803.